Translate LF→CR on PTY input to match real keyboard behavior#2
Open
nickottocode wants to merge 1 commit intomasterfrom
Open
Translate LF→CR on PTY input to match real keyboard behavior#2nickottocode wants to merge 1 commit intomasterfrom
nickottocode wants to merge 1 commit intomasterfrom
Conversation
TUIs in raw mode expect CR (0x0d) for Enter, which is what physical keyboards send. API clients naturally send LF (0x0a). This adds server-side translation in the PTY writer loop, matching tmux's approach. Safe for cooked mode since ICRNL converts CR back to LF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TUIs in raw mode expect CR (0x0d) for Enter, which is what physical keyboards send. API clients naturally send LF (0x0a). This adds server-side translation in the PTY writer loop, matching tmux's approach. Safe for cooked mode since ICRNL converts CR back to LF.