Conversation
mkst
commented
Mar 23, 2026
| # A label referenced by a jumptable. | ||
| .macro jlabel label, visibility=global | ||
| \label: | ||
| .macro jlabel label, visibility=local |
Collaborator
Author
There was a problem hiding this comment.
Is this correct? This matches the behaviour of ps2.s and splats labels.inc (macro.inc has it as global).
Collaborator
There was a problem hiding this comment.
jlabel should only need to be global when you have code and rodata split into separate files and then link them together, which is not the case for decomp.me. Local gives a better diff experience
Collaborator
Author
There was a problem hiding this comment.
Perfect, thanks for confirming :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated ps2 and then used that as a reference for ps1 and psp.
Closes out #1880.