Retrieves Firebase Project ID from the provided service credential file#143
Open
xavarius wants to merge 4 commits intodecision-labs:masterfrom
Open
Retrieves Firebase Project ID from the provided service credential file#143xavarius wants to merge 4 commits intodecision-labs:masterfrom
xavarius wants to merge 4 commits intodecision-labs:masterfrom
Conversation
Author
Author
Author
|
Dear @sabman, I'm fully aware you may need some time to review this. Could you please let me know if you would have opportunity to do it like this month? :) Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #142
The pull request adds automatic Firebase Project ID handling by retrieving it from the provided configuration/credential file.
Since the service credential file (exported from the Firebase) contains this project ID, the PR removes duplication in the client initialization.
I would suggest releasing new version with this change, possibly major one, since it's a breaking change.
PS
I have not found any confirmed Firebase service credentials json schema, which kinda makes sense to not disclosure it, but we're all working here with assumptions around the API and file schema.