Fix import guard to allow library usage#4
Open
hyeeyoungkim wants to merge 1 commit intodecirella:mainfrom
Open
Fix import guard to allow library usage#4hyeeyoungkim wants to merge 1 commit intodecirella:mainfrom
hyeeyoungkim wants to merge 1 commit intodecirella:mainfrom
Conversation
- Wrap parse_args() and main() in if __name__ guard - Add import guard tests (tests/test_import_guard.py) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
args = parser.parse_args()andmain(args)(lines 1693-1694) in anif __name__ == "__main__":guard so thatimport yescno longer triggersargument parsing and execution
Problem
The debug lines at the end of
yesc.pysit at module level (outside theif __name__guard), which means anyimport yescimmediately callsparser.parse_args()andmain(args). This prevents using yesc as a library— for example, building args programmatically and calling
main(args)fromanother script.
The commented-out try/except block (lines 1682-1691) was the original
implementation inside the guard. The current lines were placed at module level
for debugging and left in place.
Change
Add
if __name__ == "__main__":guard around lines 1693-1694 and indent them.The
'''string literal on line 1691 exits the originalif __name__block(it's at column 0), so these lines need their own guard rather than indenting
into the existing one.
Impact
python yesc.py ...): No change —__name__is"__main__",guard fires as before
yesc.exe): No change — same reasonfrom yesc import main): Now works without side effects