Fix/propagate errors for i18n entries#7773
Open
sempostma wants to merge 3 commits intodecaporg:mainfrom
Open
Conversation
yanthomasdev
reviewed
Apr 6, 2026
Contributor
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
Thanks @sempostma, I have one comment about how to fix the TS error, but overall this change sounds good to me.
| }[]; | ||
| const nonNullValues = entryValuesResults | ||
| .map(e => (e.status === 'fulfilled' ? e.value : undefined)) | ||
| .filter(e => e !== undefined); |
Contributor
There was a problem hiding this comment.
Looks like the current version of TypeScript here doesn't infer the filter removing undefined from the possible values. I think the easier fix is to just bring back the type predicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On 18n enabled websites, when for some reason the backend fails to retrieve any entries, for example because their is no internet connection: The default entry will be set to undefined since the values array is empty. This causes the following line to throw since it's accessing
defaultEntry.valuewhere defaultEntry is undefined.The following PR should fix this by not allowing an empty list to be passed to the mergeValues function in the first place and properly propagate errors.
Test plan
Checklist
Please add a
xinside each checkbox: