Skip to content

test: sonarcloud#1

Open
ddwsd wants to merge 4 commits intomasterfrom
test/sonarcloud
Open

test: sonarcloud#1
ddwsd wants to merge 4 commits intomasterfrom
test/sonarcloud

Conversation

@ddwsd
Copy link
Copy Markdown
Owner

@ddwsd ddwsd commented Nov 2, 2020

Notion link

This PR adds...

  • I've kept this PR as small as possible (~600 lines) by splitting it into PRs with manageable chunks of code
  • I've requested reviews from 1-2 reviewers
  • I've added accessibility IDs to my components
  • I've added/updated unit/integration tests
  • I've added/updated e2e tests for at least the happy flow
  • I've added Chinese translations for i18n setup
  • I've added documentation in README/Notion

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 5, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell B 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant