Skip to content

Use an Iterator + Client Builder Option#3

Merged
dcbickfo merged 1 commit intomainfrom
client-option
Apr 4, 2025
Merged

Use an Iterator + Client Builder Option#3
dcbickfo merged 1 commit intomainfrom
client-option

Conversation

@dcbickfo
Copy link
Copy Markdown
Owner

@dcbickfo dcbickfo commented Apr 4, 2025

  • Allow substituting in your own client as a rueidis client
  • Using an iterator for wait and register all to avoid copying maps to slices

@dcbickfo dcbickfo requested a review from Copilot April 4, 2025 16:51
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • go.mod: Language not supported

@dcbickfo dcbickfo merged commit 6365005 into main Apr 4, 2025
1 check passed
@dcbickfo dcbickfo deleted the client-option branch April 4, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@chriskarlin chriskarlin chriskarlin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcbickfo @chriskarlin