Open
Conversation
…really testing anything
Contributor
|
@SebastienGllmt are we going to do anything related to this pr? |
Contributor
Author
|
I don't remember if this PR worked perfectly or not. I remember properly writing tests for Carp was tricky, but I don't remember if this solved all the issues or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to fix the merge conflicts in #91 by pushing to Mitch's upstream repo. It seems Github introduced a new feature that automatically closes PRs based off certain conditions and it seems their feature is a terribly broken mess.
I recreated this PR to keep track of the proposed changes