Open
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 fal.ai Preview Deployment
TestingConnect to this preview deployment by running this on your branch: 🧪 E2E tests will run automatically against this deployment. |
Contributor
✅ E2E Tests passed
Test ArtifactsCheck the workflow run for screenshots. |
gioelecerati
force-pushed
the
rafal/graph-mode-frontend-rebased
branch
from
e7ad3c9 to
b5095b1
Compare
gioelecerati
force-pushed
the
rafal/graph-mode-frontend-rebased
branch
from
f88bb22 to
27c0870
Compare
leszko
force-pushed
the
rafal/graph-mode-frontend-rebased
branch
from
cd7a6bf to
0872579
Compare
…ow support Cherry-picked from 7d1eb0e with conflict resolution. Signed-off-by: Rafał Leszko <rafal@livepeer.org> Signed-off-by: gioelecerati <gioele@cerati.org>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafal Leszko <rafal@livepeer.org>
leszko
force-pushed
the
rafal/graph-mode-frontend-rebased
branch
from
dcf827d to
0da42df
Compare
Route graph mode source changes through handleModeChange so the backend receives input_source parameter updates during streaming. Add a useEffect to sync input_source config over WebRTC when it changes mid-stream. Also: move resolution display from toolbar to SinkNode, support nullable enums in PipelineNode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafał Leszko <rafal@livepeer.org>
Graph mode export now matches the Perform Mode flow: clicking Export opens the same ExportDialog with options to download a workflow file (with a name input dialog) or publish directly to daydream.live. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafal Leszko <rafal@livepeer.org>
Graph mode was not applying the same VRAM-based quantization logic as perform mode, leaving quantization as None even when the device VRAM is below the pipeline recommended threshold. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafał Leszko <rafal@livepeer.org>
…AM threshold Matches perform mode behavior where quantization is reset to null when the pipeline has no recommended_quantization_vram_threshold. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafał Leszko <rafal@livepeer.org>
…aming in graph mode These are runtime parameters (used in OSC, DMX, modulation, and UpdateParams) but were incorrectly marked as is_load_param=True, causing them to be disabled during streaming in graph mode. Also fix the default isLoadParam logic in PipelineNode to not assume params without an explicit is_load_param are load params. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafał Leszko <rafal@livepeer.org>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafał Leszko <rafal@livepeer.org>
…aph mode Graph mode was unconditionally enabling VACE and missing per-node quantization defaults, causing OOM on GPUs that require FP8. Quantization now computes the VRAM-based default per pipeline node, and VACE is only enabled when edges connect to vace_input_frames or vace_input_masks ports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafal Leszko <rafal@livepeer.org>
…stream start The PipelineNode warning said resolution would be adjusted, but the actual adjustment was not happening. Node params (height/width) now get adjusted before being passed to loadPipeline, matching Perform mode behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafał Leszko <rafal@livepeer.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.