move variable declarations out of control structures to avoid warning on SC 3.15#264
Open
HotwheelsSisyphus wants to merge 2 commits intodavidgranstrom:mainfrom
Open
move variable declarations out of control structures to avoid warning on SC 3.15#264HotwheelsSisyphus wants to merge 2 commits intodavidgranstrom:mainfrom
HotwheelsSisyphus wants to merge 2 commits intodavidgranstrom:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of Jordan's recent work on SC's parser (PyrParseNode.cpp) seems to have resulted in SC now displaying "uninlineable" warnings on startup where it didn't previously... they're still just warnings, but it's easy enough to fix the scnvim code that generates them, so I did.
The warnings in question:
Everything works as before, but no warning on startup, and it saves you probably 0.0002 picoseconds of your precious time (very scientific estimate) because the code now presumably inlines properly.