Remove waitlist text and fix last used badge bug#60
Merged
mattdjenkinson merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
kevwilliams
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a "last used" badge for identity provider (IDP) login buttons, improves the registration/waitlist UI copy, and adds i18n support across all locale files.
Features
1. Last Used Badge on IDP Buttons
last-used-idp-id) with a 1-year expiry.Technical details:
setLastUsedIdpId()andgetLastUsedIdpId()inlib/cookies.tscreateNewSessionFromIdpIntent(when returning redirect, including email verification and MFA flows)registerUserAndLinkToIDP(when registration with IDP linking succeeds)idpIdis passed through the success flow: success page →loginSuccess/linkingSuccess→IdpSignin→createNewSessionFromIdpIntentBaseButtonshows the badge whenisLastUsedis true; custom props are destructured to avoid passing them to the DOM2. Registration / Waitlist UI Updates
waitlistnamespace withtitle,subtitle, anddescriptionfor clearer hierarchy.h3, subtitle inh1, description inpfor improved visual hierarchy.Locale Updates
All locale files (de, es, it, pl, ru, zh) were updated to match
en.json:loginname.registerwaitlist.titlewaitlist.subtitlewaitlist.descriptionregister.alreadyRegisteredregister.loginNowidp.lastUsedFiles Changed
Core Feature
apps/login/src/lib/cookies.ts– Cookie helpers for last-used IDPapps/login/src/components/idps/base-button.tsx– Badge UI and prop handlingapps/login/src/components/sign-in-with-idp.tsx– PasslastUsedIdpIdandisLastUsedapps/login/src/components/idp-signin.tsx– PassidpIdto session creationapps/login/src/components/idps/pages/login-success.tsx– PassidpIdtoIdpSigninapps/login/src/components/idps/pages/linking-success.tsx– PassidpIdtoIdpSigninapps/login/src/lib/server/idp.ts– Set cookie on success, passidpIdthrough flowapps/login/src/lib/server/register.ts– Set cookie on successful IDP registrationapps/login/src/app/(main)/(boxed)/idp/[provider]/success/page.tsx– PassidpIdto success componentsPages Using SignInWithIdp (pass
lastUsedIdpId)apps/login/src/app/(main)/(illustration)/loginname/page.tsxapps/login/src/app/(main)/(boxed)/idp/page.tsxapps/login/src/app/(main)/(illustration)/register/page.tsxapps/login/src/app/(main)/(boxed)/authenticator/set/page.tsxapps/login/src/app/(main)/(boxed)/idp/link/page.tsxUI Updates
apps/login/src/app/(main)/(illustration)/register/page.tsx– Waitlist title/subtitle/descriptionapps/login/src/app/(main)/(illustration)/register/_login-btn.tsx– Removed waitlist blockLocales
apps/login/locales/de.jsonapps/login/locales/en.jsonapps/login/locales/es.jsonapps/login/locales/it.jsonapps/login/locales/pl.jsonapps/login/locales/ru.jsonapps/login/locales/zh.json