CSHARP-994 Add AsyncEnumerable support to RowSet#617
Open
verdie-g wants to merge 8 commits intodatastax:masterfrom
Open
CSHARP-994 Add AsyncEnumerable support to RowSet#617verdie-g wants to merge 8 commits intodatastax:masterfrom
verdie-g wants to merge 8 commits intodatastax:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any async method in
Mappercan block the thread if there are more than one page inRowSet. This can easily starve the thread pool and obliterate the performance of your app.The proper fix it to make
RowSetimplementIAsyncEnumerable. The latter is only available in .NET Core 3 though. I could make the driver target this version but it reached end of life 7 years ago. According to versionsof.net/core, the oldest active .NET version is 8 so that's what I picked.The PR does not compile right now because the .NET 8 target generates a bunch of obsolete warnings (upgraded to errors) about
System.Runtime.ConstrainedExecutionand TLS1.X. Also, tests are missing.I would like to get some first feedbacks before resuming the work, especially around adding this new target framework. I believe it's time to add new targets as .NET Standard is now 8 years old.