Skip to content

[-] chore: appease linter#412

Merged
ajalon1 merged 1 commit intodatarobot-oss:mainfrom
ajalon1:aj/chore-lint
Mar 30, 2026
Merged

[-] chore: appease linter#412
ajalon1 merged 1 commit intodatarobot-oss:mainfrom
ajalon1:aj/chore-lint

Conversation

@ajalon1
Copy link
Copy Markdown
Contributor

@ajalon1 ajalon1 commented Mar 30, 2026

RATIONALE

Handle some lints in main.

CHANGES

PR Automation

Comment-Commands: Trigger CI by commenting on the PR:

  • /trigger-smoke-test or /trigger-test-smoke - Run smoke tests
  • /trigger-install-test or /trigger-test-install - Run installation tests

Labels: Apply labels to trigger workflows:

  • run-smoke-tests or go - Run smoke tests on demand (only works for non-forked PRs)

Important

For Forked PRs: If you're an external contributor, the run-smoke-tests label won't work. A maintainer must manually trigger the "Fork PR Smoke Tests" workflow from the Actions tab, providing your PR number. Please comment requesting a maintainer review if you need smoke tests to run.


Note

Low Risk
Test-only assertion cleanups (switching to require.NoError and simplifying assert.Contains) with no production code changes, so impact is limited to test behavior/strictness.

Overview
Cleans up several tests to satisfy linting and simplify assertions.

Replaces assert.NoError with require.NoError in cmd/root_test.go to fail fast on command execution errors, and simplifies version string checks in internal/version/version_test.go by using assert.Contains directly (removing the extra strings.Contains/assert.True pattern). Minor formatting tweak in internal/tools/prerequisites_test.go to keep the version.Version override/restore clearer.

Written by Cursor Bugbot for commit 48ef874. This will update automatically on new commits. Configure here.

@ajalon1 ajalon1 requested a review from a team March 30, 2026 22:06
@ajalon1 ajalon1 merged commit f7d11d1 into datarobot-oss:main Mar 30, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant