Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATIONALE
Handle some lints in
main.CHANGES
PR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: If you're an external contributor, the
run-smoke-testslabel won't work. A maintainer must manually trigger the "Fork PR Smoke Tests" workflow from the Actions tab, providing your PR number. Please comment requesting a maintainer review if you need smoke tests to run.Note
Low Risk
Test-only assertion cleanups (switching to
require.NoErrorand simplifyingassert.Contains) with no production code changes, so impact is limited to test behavior/strictness.Overview
Cleans up several tests to satisfy linting and simplify assertions.
Replaces
assert.NoErrorwithrequire.NoErrorincmd/root_test.goto fail fast on command execution errors, and simplifies version string checks ininternal/version/version_test.goby usingassert.Containsdirectly (removing the extrastrings.Contains/assert.Truepattern). Minor formatting tweak ininternal/tools/prerequisites_test.goto keep theversion.Versionoverride/restore clearer.Written by Cursor Bugbot for commit 48ef874. This will update automatically on new commits. Configure here.