fix Fixing error where complex column types contain a list or null#403
Open
jhsb25 wants to merge 3 commits intodatacoves:mainfrom
Open
fix Fixing error where complex column types contain a list or null#403jhsb25 wants to merge 3 commits intodatacoves:mainfrom
jhsb25 wants to merge 3 commits intodatacoves:mainfrom
Conversation
added 2 commits
September 20, 2023 17:16
…t or string), also changing query to pull row where all variant columns have a value
…t or string), also changing query to pull row where all variant columns have a value
jhsb25
changed the title
…t or string), also changing query to pull row where all variant columns have a value
Contributor
|
hi @jhsb25, thank you for your contribution would you be able to provide a test that covers this code you are introducing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current when i use the tool to generate a table from a source that needs to be flattened i get an error when the columns are either null or of a json list format, this PR goes some way to try to ensure that all variant columns queried return a non null value and when the variant in the column is not an object (eg list) then that denesting is skipped.