Skip to content

fix: Validate Firebase config before injection (DAT-11942) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riffellabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Validate Firebase config before injection (DAT-11942) #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 36 additions & 5 deletions frontend/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,33 @@ const listExtensions = (): Extension[] => {

const extensions = listExtensions();

const getExtensionConfig = (name: string): string => {
const getExtensionConfig = (name: string): Record<string, unknown> | undefined => {
const extension = extensions.find((it) => it.name === name);

if (!extension) {
console.warn(`Extension ${name} not found`);
return undefined;
}

return JSON.stringify(extension?.config);
return extension.config;
};

/**
* Validates that Firebase config has all required keys.
* Returns true only if apiKey, projectId, and appId are present and non-empty.
* Implements "Atomic Config or Nothing" principle - config must be complete or not used.
*/
const isFirebaseConfigComplete = (
config: Record<string, unknown> | undefined,
): boolean => {
if (!config) return false;

const requiredKeys = ["apiKey", "projectId", "appId"];

return requiredKeys.every((key) => {
const value = config[key];
return typeof value === "string" && value.trim().length > 0;
});
};

const buildVariables = () => {
Expand All @@ -59,12 +78,24 @@ const buildVariables = () => {
__APP_DEPLOY_USERNAME__: JSON.stringify(""),
__APP_DEPLOY_APPNAME__: JSON.stringify(""),
__APP_DEPLOY_CUSTOM_DOMAIN__: JSON.stringify(""),
__STACK_AUTH_CONFIG__: JSON.stringify(getExtensionConfig(ExtensionName.STACK_AUTH)),
__FIREBASE_CONFIG__: JSON.stringify(
getExtensionConfig(ExtensionName.FIREBASE_AUTH),
__STACK_AUTH_CONFIG__: JSON.stringify(
JSON.stringify(getExtensionConfig(ExtensionName.STACK_AUTH)),
),
};

// Only inject Firebase config if it's complete with all required keys
// Implements "Atomic Config or Nothing" to prevent auth/invalid-api-key errors
const firebaseConfig = getExtensionConfig(ExtensionName.FIREBASE_AUTH);
if (isFirebaseConfigComplete(firebaseConfig)) {
defines.__FIREBASE_CONFIG__ = JSON.stringify(JSON.stringify(firebaseConfig));
console.log("Firebase config validated and injected successfully");
} else {
console.warn(
"Firebase config is incomplete (missing apiKey, projectId, or appId). " +
"Skipping injection to prevent auth errors in Preview.",
);
}

return defines;
};

Expand Down