Skip to content

perf: array comparison reference equality + numeric fast path #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
He-Pin wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −3
Open

perf: array comparison reference equality + numeric fast path #674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions sjsonnet/src/sjsonnet/Evaluator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,11 +1190,24 @@ class Evaluator(
val len = math.min(x.length, y.length)
var i = 0
while (i < len) {
val cmp = compare(x.value(i), y.value(i))
if (cmp != 0) return cmp
val xi = x.value(i)
val yi = y.value(i)
// Reference equality short-circuit for shared array elements
if (!(xi eq yi)) {
// Inline numeric fast path to avoid polymorphic compare() dispatch
val cmp = xi match {
case xn: Val.Num =>
yi match {
case yn: Val.Num => java.lang.Double.compare(xn.asDouble, yn.asDouble)
case _ => compare(xi, yi)
}
case _ => compare(xi, yi)
}
if (cmp != 0) return cmp
}
i += 1
}
Ordering[Int].compare(x.length, y.length)
Integer.compare(x.length, y.length)
case _ => Error.fail("Cannot compare " + x.prettyName + " with " + y.prettyName, x.pos)
}

Expand Down