perf: optimize std.map, std.flatMap, and std.filterMap allocations#670
Open
He-Pin wants to merge 1 commit intodatabricks:masterfrom
Open
perf: optimize std.map, std.flatMap, and std.filterMap allocations#670He-Pin wants to merge 1 commit intodatabricks:masterfrom
He-Pin wants to merge 1 commit intodatabricks:masterfrom
Conversation
Three stdlib array function optimizations: 1. std.map: Replace .map(closure) with pre-sized array + while-loop. Eliminates closure allocation and intermediate array creation. 2. std.flatMap: Two-pass approach for array variant: - First pass: apply function, collect sub-arrays, count total length - Second pass: System.arraycopy into pre-sized result array Avoids .flatMap's intermediate ArrayBuilder resizing. 3. std.filterMap: Replace .flatMap + Option boxing with while-loop and ArrayBuilder. Eliminates Some/None wrapping per element. Upstream: jit branch commit 9cb95af Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Three stdlib array operations use Scala collection APIs that allocate intermediate structures:
std.map: Uses.map()which creates closures and temporary arraysstd.flatMap: Uses.flatMap { ... }with intermediateArraySeqallocationsstd.filterMap: Uses.flatMap { ... Some/None }withOptionboxingKey Design Decision
std.mapusesLazyApply1to preserve lazy evaluation semanticsstd.flatMapuses a two-pass approach: collect sub-arrays + compute total size, thenSystem.arraycopyinto pre-allocated resultstd.filterMapreplacesOptionboxing with direct while-loop +ArrayBuilderModification
1.
std.map→ pre-sized Array + while-loopPre-sizes the output array and uses a while-loop, avoiding
.map()closure allocation. UsesLazyApply1to preserve lazy evaluation semantics.2.
std.flatMap→ two-pass with System.arraycopyPass 1: Evaluate and collect sub-arrays, computing total size.
Pass 2: Pre-allocate result array and copy elements with
System.arraycopy.3.
std.filterMap→ while-loop with ArrayBuilderReplaces
.flatMap { ... Some/None }with a while-loop that directly appends matching elements to anArrayBuilder, avoidingOptionallocation.Benchmark Results
JMH Regression Suite (1 fork, 3 warmup, 1 measurement iteration)
All 35 benchmarks within ±5% noise margin. This is an incremental building-block optimization.
Scala Native Hyperfine
These are allocation-reduction optimizations for
std.map,std.flatMap, andstd.filterMap. In isolation, the JMH impact is within noise for the current benchmark suite (which doesn't have dedicated map/flatMap-heavy workloads). Native impact is proportional.Analysis
The -7.1% improvement on setUnion is the most notable result — set operations internally use map/filter operations, so the allocation reduction is visible there. The map/flatMap/filterMap optimizations are building-block improvements that reduce garbage collection pressure and eliminate intermediate collection allocations. These compound with other optimizations when applied together.
References
Upstream: jit branch commit
9cb95af4(map/flatMap/filterMap optimizations)Upstream jit branch exploration at he-pin/sjsonnet@jit
Result
Incremental building-block optimization with no regressions. Eliminates intermediate collection allocations in
std.map,std.flatMap, andstd.filterMap. -7.1% improvement on setUnion benchmark.