Improve IDE settings prompt formatting and default to yes#4705
Open
anton-107 wants to merge 2 commits intoantonnek/auto-session-namesfrom
Open
Improve IDE settings prompt formatting and default to yes#4705anton-107 wants to merge 2 commits intoantonnek/auto-session-namesfrom
anton-107 wants to merge 2 commits intoantonnek/auto-session-namesfrom
Conversation
anton-107
requested review from
andrewnester,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: b221e9b
16 interesting tests: 7 SKIP, 6 RECOVERED, 3 flaky
Top 20 slowest tests (at least 2 minutes):
|
anton-107
force-pushed
the
antonnek/auto-session-names
branch
from
d678d8d to
857404f
Compare
…4693) ## Summary - Replace `time.Now().UnixMilli()` with `nowMilli()` in testserver fake implementations (pipelines, catalogs, external locations, registered models) to guarantee strictly increasing millisecond timestamps - Add a `ruleguard` lint rule to prevent `time.Now().UnixMilli()` in `libs/testserver/` (except `fake_workspace.go` where the helper is defined) - Fix `CreatedAt`/`UpdatedAt` in create handlers to use the same timestamp value, matching real API behavior Fixes flaky test `TestAccept/bundle/resource_deps/pipelines_recreate/DATABRICKS_BUNDLE_ENGINE=direct` where a pipeline's `last_modified` and a job's `created_time` could collide to the same millisecond, causing `[UNIX_TIME_MILLIS][0]` vs `[UNIX_TIME_MILLIS][1]` index mismatch in test output. Example failure: https://github.com/databricks/cli/actions/runs/22710298364/job/65846540329 ## Test plan - [x] `TestAccept/bundle/resource_deps/pipelines_recreate` passes consistently (verified with `-count=3`) - [x] `make lintfull` passes with 0 issues - [x] `make test` passes (template test failures are pre-existing and unrelated) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
- Wrap settings JSON in { } with proper indentation for visual clarity
- Add blank lines around the settings block
- Default to yes (Y/n) when prompting to apply settings
- Shorten inline comments for less noise
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
anton-107
force-pushed
the
antonnek/ide-settings-prompt-improvements
branch
from
9869d22 to
b221e9b
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
approved these changes
Mar 12, 2026
Member
simonfaltum
left a comment
simonfaltum
left a comment
There was a problem hiding this comment.
[Agent Swarm Review] Verdict: Approved
- 0 Critical
- 0 Major
- 0 Gap
- 2 Nit
- 1 Suggestion
Good UX improvement for the IDE settings prompt. Two nits: the yes/no handling is narrower than the standard pattern, and the gorule/testserver changes are unrelated to the prompt improvements.
| func promptUserForUpdate(ctx context.Context, ide, connectionName string, missing *missingSettings) (bool, error) { | ||
| question := fmt.Sprintf( | ||
| "The following settings will be applied to %s for '%s':\n%s\nApply these settings?", | ||
| "The following settings will be applied to %s for '%s':\n\n%s\n\nApply these settings?", |
Member
There was a problem hiding this comment.
[Agent Swarm Review] [Nit]
The change from cmdio.AskYesOrNo to cmdio.Ask with manual [Y/n] handling means only exact "y" matches are accepted. strings.EqualFold(strings.TrimSpace(ans), "y") or also accepting "yes" would be more robust.
| @@ -0,0 +1,14 @@ | |||
| package gorules | |||
Member
There was a problem hiding this comment.
[Agent Swarm Review] [Nit]
This new gorule and the testserver timestamp changes are unrelated to the IDE settings prompt improvements. Consider splitting into a separate PR for cleaner review.
Contributor
There was a problem hiding this comment.
Seems indeed unrelated. The output changes are good though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ }with proper indentation so it stands out visually[Y/n]) — pressing Enter accepts// Global settinginstead of// Global setting that affects all remote ssh connections)Stacked on #4701.
Test plan
🤖 Generated with Claude Code