refactor(planner): Move all metadata out#7731
Merged
mergify[bot] merged 7 commits intodatabendlabs:mainfrom Sep 20, 2022
Merged
refactor(planner): Move all metadata out#7731mergify[bot] merged 7 commits intodatabendlabs:mainfrom
mergify[bot] merged 7 commits intodatabendlabs:mainfrom
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mergify
bot
added
the
pr-refactor
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
leiysky
approved these changes
Sep 19, 2022
sundy-li
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Part of #7593
This PR will create a new crate
common-planner. In the following PRs, I will move the new planner out and merge the old ones.NOTE: This PR is not a simple COPY and PASTE. I rewrote some of the functions and added docs for public APIs. Please review carefully!