fix: treat X'...' as binary literal#19635
Closed
sundy-li wants to merge 1 commit intodatabendlabs:mainfrom
Closed
Conversation
Contributor
|
At least one test kind must be checked in the PR description. |
Contributor
|
At least one type of change must be checked in the PR description. |
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
sundy-li
commented
Mar 30, 2026
| ---------- Input ---------- | ||
| x'ABC' | ||
| ---------- Output --------- | ||
| error: |
Member
Author
There was a problem hiding this comment.
git diff --check flags trailing whitespace on this added line. Please remove the extra space after error: so the branch stays clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Fixes #19600
X...literals as binary values instead of numeric hex integers\n- keep MySQL-style0x...literals on the numeric path\n- add parser and SQL regression coverage for binary typing and arithmetic rejection\n\n## Tests\n\n- [x] Unit Test\n- [x] Logic Test\n- [ ] Benchmark Test\n- [ ] No Test - Pair with the reviewer to explain why\n\nValidation run:\n\n-cargo test -p databend-common-ast --test it parser::test_expr\n-cargo check -p databend-common-sql --lib\n-cargo clippy -p databend-common-ast --all-targets -p databend-common-sql --lib -- -D warnings\n\n## Type of change\n\n- [x] Bug fix (non-breaking change which fixes an issue)This change is