fix(query): support IF NOT EXISTS for ALTER TABLE ADD COLUMN#19615
Merged
b41sh merged 10 commits intodatabendlabs:mainfrom Apr 5, 2026
Merged
fix(query): support IF NOT EXISTS for ALTER TABLE ADD COLUMN#19615b41sh merged 10 commits intodatabendlabs:mainfrom
b41sh merged 10 commits intodatabendlabs:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fffb788166
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sundy-li
commented
Mar 25, 2026
src/query/service/src/interpreters/interpreter_table_add_column.rs
Outdated
Show resolved
Hide resolved
Member
Author
|
ci check is failed, please fix the check |
sundy-li
commented
Mar 26, 2026
src/query/service/src/interpreters/interpreter_table_add_column.rs
Outdated
Show resolved
Hide resolved
sundy-li
commented
Mar 27, 2026
b41sh
approved these changes
Apr 4, 2026
Remove error handling for existing columns in ALTER TABLE.
Merged
via the queue into
databendlabs:main
with commit Apr 5, 2026
15a82a5
176 of 178 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
ALTER TABLE ... ADD COLUMN IF NOT EXISTSIF NOT EXISTSis presentChanges
if_not_existsflag.IF NOT EXISTSis specified.Tests
Validation commands:
Type of change
Fixes #19611
This change is