Fix performance report template for Bokeh 3.9#9213
Open
saarantras wants to merge 1 commit intodask:mainfrom
Open
Fix performance report template for Bokeh 3.9#9213saarantras wants to merge 1 commit intodask:mainfrom
saarantras wants to merge 1 commit intodask:mainfrom
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 31 files ± 0 31 suites ±0 11h 20m 29s ⏱️ + 7m 5s For more details on these failures, see this check. Results for commit dfee6f8. ± Comparison against base commit 595d591. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #9205.
While trying to generate
distributed.performance_reportlogs, I was still hitting a Bokeh 3.9 template error. The compatibility shim added in #9205 fixed the general template rename, butdistributed/dashboard/templates/performance_report.htmlwas still extendingfile.html, which does not exist in Bokeh 3.9's template namespace.(I have not checked <3.9 Bokeh releases.)