Skip to content

feat: expose full TransactionRecord through FFI and wallet events #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 4 commits into from
Apr 1, 2026
+689 −290

fix: correct `net_amount` assertion in FFI callback integration test

416d91e
Select commit
Loading
Failed to load commit list.
Merged

feat: expose full TransactionRecord through FFI and wallet events #614

fix: correct `net_amount` assertion in FFI callback integration test
416d91e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 1, 2026 in 1s

67.53% (+0.08%) compared to 09f03e0

View this Pull Request on Codecov

67.53% (+0.08%) compared to 09f03e0

Details

Codecov Report

❌ Patch coverage is 93.23944% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.53%. Comparing base (09f03e0) to head (416d91e).

Files with missing lines Patch % Lines
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 9 Missing ⚠️
key-wallet-ffi/src/managed_account.rs 95.38% 6 Missing ⚠️
key-wallet-ffi/src/types.rs 97.38% 4 Missing ⚠️
dash-spv-ffi/src/callbacks.rs 94.44% 3 Missing ⚠️
key-wallet-manager/src/events.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #614      +/-   ##
=============================================
+ Coverage      67.45%   67.53%   +0.08%     
=============================================
  Files            320      320              
  Lines          67949    68169     +220     
=============================================
+ Hits           45832    46038     +206     
- Misses         22117    22131      +14
Files with missing lines Coverage Δ
key-wallet-manager/src/lib.rs 61.71% <100.00%> (-0.79%) ⬇️
key-wallet-manager/src/test_helpers.rs 97.59% <100.00%> (ø)
key-wallet/src/managed_account/mod.rs 55.21% <100.00%> (+0.14%) ⬆️
...wallet/src/transaction_checking/account_checker.rs 66.51% <100.00%> (+0.05%) ⬆️
...-wallet/src/transaction_checking/wallet_checker.rs 97.83% <ø> (ø)
key-wallet-manager/src/events.rs 0.00% <0.00%> (ø)
dash-spv-ffi/src/callbacks.rs 82.25% <94.44%> (+1.66%) ⬆️
key-wallet-ffi/src/types.rs 79.01% <97.38%> (+2.48%) ⬆️
key-wallet-ffi/src/managed_account.rs 48.80% <95.38%> (+3.88%) ⬆️
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

View more details on Codecov