Skip to content

feat(key-wallet): add BlockchainIdentities account type #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lklimek wants to merge 8 commits into
base: v0.42-dev
Choose a base branch
from

fix: add BlockchainIdentities variants to involved_receive_addresses(…

36dd6ff
Select commit
Loading
Failed to load commit list.
Open

feat(key-wallet): add BlockchainIdentities account type #554

fix: add BlockchainIdentities variants to involved_receive_addresses(…
36dd6ff
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 1, 2026 in 1s

67.00% (-0.45%) compared to 09f03e0

View this Pull Request on Codecov

67.00% (-0.45%) compared to 09f03e0

Details

Codecov Report

❌ Patch coverage is 46.36752% with 251 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.00%. Comparing base (09f03e0) to head (36dd6ff).

Files with missing lines Patch % Lines
key-wallet-ffi/src/transaction_checking.rs 0.00% 56 Missing ⚠️
...wallet/src/transaction_checking/account_checker.rs 44.11% 38 Missing ⚠️
key-wallet-ffi/src/address_pool.rs 0.00% 36 Missing ⚠️
...wallet/src/managed_account/managed_account_type.rs 14.28% 30 Missing ⚠️
.../src/managed_account/managed_account_collection.rs 76.08% 22 Missing ⚠️
key-wallet-ffi/src/managed_account.rs 0.00% 16 Missing ⚠️
key-wallet/src/managed_account/mod.rs 0.00% 16 Missing ⚠️
key-wallet/src/account/account_collection.rs 80.00% 12 Missing ⚠️
key-wallet-ffi/src/types.rs 0.00% 8 Missing ⚠️
...src/transaction_checking/transaction_router/mod.rs 33.33% 8 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #554      +/-   ##
=============================================
- Coverage      67.45%   67.00%   -0.45%     
=============================================
  Files            320      320              
  Lines          67949    68417     +468     
=============================================
+ Hits           45832    45845      +13     
- Misses         22117    22572     +455
Files with missing lines Coverage Δ
key-wallet/src/account/mod.rs 66.76% <100.00%> (+3.97%) ⬆️
key-wallet/src/wallet/helper.rs 42.79% <73.33%> (+0.95%) ⬆️
key-wallet/src/account/account_type.rs 55.72% <72.22%> (+5.99%) ⬆️
key-wallet-ffi/src/types.rs 75.16% <0.00%> (-1.37%) ⬇️
...src/transaction_checking/transaction_router/mod.rs 84.21% <33.33%> (-5.05%) ⬇️
key-wallet/src/account/account_collection.rs 60.17% <80.00%> (+2.99%) ⬆️
key-wallet-ffi/src/managed_account.rs 48.78% <0.00%> (+3.86%) ⬆️
key-wallet/src/managed_account/mod.rs 53.68% <0.00%> (-1.39%) ⬇️
.../src/managed_account/managed_account_collection.rs 58.07% <76.08%> (+2.40%) ⬆️
...wallet/src/managed_account/managed_account_type.rs 21.53% <14.28%> (-0.69%) ⬇️
... and 3 more

... and 14 files with indirect coverage changes

View more details on Codecov