Skip to content

chore: update rust-dashcore dependency to store TransactionContext in TransactionRecord#35

Closed
dashinfraclaw wants to merge 1 commit intodashpay:mainfrom
dashinfraclaw:test-rust-dashcore-pr-582
Closed

chore: update rust-dashcore dependency to store TransactionContext in TransactionRecord#35
dashinfraclaw wants to merge 1 commit intodashpay:mainfrom
dashinfraclaw:test-rust-dashcore-pr-582

Conversation

@dashinfraclaw
Copy link
Copy Markdown

@dashinfraclaw dashinfraclaw commented Mar 26, 2026

Automated integration test for dashpay/rust-dashcore#582.

What: Updated all dashcore/dashcore-rpc git dependencies to PR HEAD commit (5114330ae564858803d656efba84bb4adacb2a2e).

Why: Validates that the changes in rust-dashcore PR #582 (refactor: store TransactionContext in TransactionRecord) compile and pass CI against this repository.

Changes: Dependency pointer update only — no functional code changes.

Summary by CodeRabbit

  • Chores
    • Updated dashcore-rpc dependency from a tagged release to a specific commit reference.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

Warning

Rate limit exceeded

@dashinfraclaw has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b65d4fd1-e383-4b75-9ece-bb3b9030949e

📥 Commits

Reviewing files that changed from the base of the PR and between 819eea7 and 1c04382.

📒 Files selected for processing (3)
  • dash-sdk-android/src/main/rust/Cargo.toml
  • dash-sdk-bindings/Cargo.toml
  • platform-mobile/Cargo.toml
📝 Walkthrough

Walkthrough

The dashcore-rpc dependency in platform-mobile/Cargo.toml is updated from a git tag reference (v0.39.6) to a specific commit revision (5114330ae564858803d656efba84bb4adacb2a2e).

Changes

Cohort / File(s) Summary
Dependency Update
platform-mobile/Cargo.toml
Updated dashcore-rpc git dependency from tag v0.39.6 to specific commit revision.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit hops through code so bright,
Git revisions set just right,
From tag to commit, the journey flows,
In Cargo.toml, the wisdom grows! 📦✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title references storing TransactionContext in TransactionRecord, which is the actual change in rust-dashcore PR #582 being tested, but the changeset only updates a dependency pointer to a specific commit hash with no visible functional changes in this repository. Consider clarifying whether the title should reflect the immediate change (dependency update) or the upstream change being validated. A title like 'chore: update dashcore-rpc dependency to latest commit' would more directly describe what this PR does.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

… TransactionRecord

Update dashcore/dashcore-rpc git dependencies to 5114330ae564858803d656efba84bb4adacb2a2e
for integration testing of dashpay/rust-dashcore#582.
@dashinfraclaw dashinfraclaw force-pushed the test-rust-dashcore-pr-582 branch from 819eea7 to 1c04382 Compare March 26, 2026 08:18
@dashinfraclaw dashinfraclaw deleted the test-rust-dashcore-pr-582 branch March 26, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant