test: RPC coverage linter + related fixes for listaddressbalances#7279
test: RPC coverage linter + related fixes for listaddressbalances#7279knst wants to merge 6 commits intodashpay:developfrom
Conversation
8aed477 test: fix RPC coverage check (Brandon Odiwuor) 2630b64 test: add abortrescan RPC test (Brandon Odiwuor) Pull request description: This is bitcoin#27593 cleaned up / rebased, now that the legacy wallet has been dropped. Closes bitcoin#27593. ACKs for top commit: maflcko: lgtm ACK 8aed477 cedwies: ACK 8aed477 Tree-SHA512: 14a28b1ef0c1f63236d04c2ff6c11adddc40642e4a23d30398e8a03fc47f911465af91affc6e66ee2d548515ef4f65fb1cb5d69985c5a771a17b1c9c009f48ad Co-authored-by: merge-script <fanquake@gmail.com>
|
✅ Review complete (commit 53cd792) |
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
WalkthroughThe PR refactors the Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
This backport looks clean on the checked-out SHA. listaddressbalances is moved to the wallet RPC coins module and still registered correctly, and the functional-test coverage plumbing change does what it intends: the cache node now advertises wallet RPCs for coverage reference generation via uses_wallet=True, while tests that never opt into wallet options still run with -disablewallet. I did not find a Dash-specific incompatibility or missing prerequisite on this head.
Reviewed commit: 53cd792
Issue being fixed or feature implemented
Further investigation discovered the bug, that exclude all wallet RPCs from coverage linter.
What was done?
listaddressbalanceslistaddressbalancesmoved between files to where it is supposed to belistaddressbalancesabortrescanRPC)Backport candidate
only this commit is considerable useful for backporting: fix: RPC doc for listaddressbalances
How Has This Been Tested?
See updates in functional tests
Breaking Changes
N/A
Checklist: