feat!: migrate additional indexes from synchronous to async operation

doc/release-notes-7101.md

@@ -0,0 +1,12 @@
+## Indexes
+
+### Async Index Migration (#7101)
+
+`TimestampIndex`, `SpentIndex`, and `AddressIndex` have been migrated from synchronous to asynchronous operation, following the same pattern as `TxIndex` and other indexes using `BaseIndex` framework.
+
+When enabling an index for the first time, the node will build the index in the background while remaining fully operational. Progress can be monitored via the `getindexinfo` RPC.
+
+Existing nodes with indexes enabled will automatically migrate data from the old location (block index database) to new separate databases on first startup. This migration may take 20-40 minutes or longer depending on hardware specifications and index sizes. The node will log progress during migration.
+
+Breaking changes:
+- `SpentIndex` and `AddressIndex` are incompatible with pruned nodes as they require access to undo data now

src/Makefile.am

@@ -157,8 +157,6 @@ BITCOIN_CORE_H = \
   active/masternode.h \
   active/quorums.h \
   addrdb.h \
-  addressindex.h \
-  spentindex.h \
   addrman.h \
   addrman_impl.h \
   attributes.h \
@@ -249,10 +247,17 @@ BITCOIN_CORE_H = \
   httprpc.h \
   httpserver.h \
   i2p.h \
+  index/addressindex.h \
+  index/addressindex_types.h \
+  index/addressindex_util.h \
   index/base.h \
   index/blockfilterindex.h \
   index/coinstatsindex.h \
   index/disktxpos.h \
+  index/spentindex.h \
+  index/spentindex_types.h \
+  index/timestampindex.h \
+  index/timestampindex_types.h \
   index/txindex.h \
   indirectmap.h \
   init.h \
@@ -346,7 +351,6 @@ BITCOIN_CORE_H = \
   rpc/blockchain.h \
   rpc/client.h \
   rpc/evo_util.h \
-  rpc/index_util.h \
   rpc/mempool.h \
   rpc/mining.h \
   rpc/protocol.h \
@@ -381,7 +385,6 @@ BITCOIN_CORE_H = \
   support/events.h \
   support/lockedpool.h \
   sync.h \
-  timestampindex.h \
   threadsafety.h \
   timedata.h \
   torcontrol.h \
@@ -487,7 +490,6 @@ libbitcoin_node_a_SOURCES = \
   active/masternode.cpp \
   active/quorums.cpp \
   addrdb.cpp \
-  addressindex.cpp \
   addrman.cpp \
   banman.cpp \
   batchedlogger.cpp \
@@ -535,9 +537,13 @@ libbitcoin_node_a_SOURCES = \
   httprpc.cpp \
   httpserver.cpp \
   i2p.cpp \
+  index/addressindex.cpp \
+  index/addressindex_util.cpp \
   index/base.cpp \
   index/blockfilterindex.cpp \
   index/coinstatsindex.cpp \
+  index/spentindex.cpp \
+  index/timestampindex.cpp \
   index/txindex.cpp \
   init.cpp \
   instantsend/db.cpp \
@@ -600,7 +606,6 @@ libbitcoin_node_a_SOURCES = \
   rpc/coinjoin.cpp \
   rpc/evo.cpp \
   rpc/fees.cpp \
-  rpc/index_util.cpp \
   rpc/masternode.cpp \
   rpc/mempool.cpp \
   rpc/governance.cpp \

src/core_write.cpp

@@ -19,8 +19,7 @@
 #include <util/strencodings.h>
 #include <util/system.h>
 
-#include <addressindex.h>
-#include <spentindex.h>
+#include <index/spentindex.h>
 
 #include <evo/assetlocktx.h>
 #include <evo/cbtx.h>

src/dbwrapper.h

@@ -392,6 +392,22 @@ class CDBWrapper
     {
         pdb->CompactRange(nullptr, nullptr);
     }
+
+    /**
+     * Compact a specific range of keys in the database.
+     */
+    template<typename K>
+    void CompactRange(const K& key_begin, const K& key_end) const
+    {
+        CDataStream ssKey1(SER_DISK, CLIENT_VERSION), ssKey2(SER_DISK, CLIENT_VERSION);
+        ssKey1.reserve(DBWRAPPER_PREALLOC_KEY_SIZE);
+        ssKey2.reserve(DBWRAPPER_PREALLOC_KEY_SIZE);
+        ssKey1 << key_begin;
+        ssKey2 << key_end;
+        leveldb::Slice slKey1(CharCast(ssKey1.data()), ssKey1.size());
+        leveldb::Slice slKey2(CharCast(ssKey2.data()), ssKey2.size());
+        pdb->CompactRange(&slKey1, &slKey2);
+    }
 };
 
 template<typename CDBTransaction>