DAOS-17444 placement: improve layout computation performance#17688
Open
gnailzenh wants to merge 1 commit intorelease/2.6from
Open
DAOS-17444 placement: improve layout computation performance#17688gnailzenh wants to merge 1 commit intorelease/2.6from
gnailzenh wants to merge 1 commit intorelease/2.6from
Conversation
- remove _get_target and _get_dom, these function are not required. pool_map of DAOS can guarantee extension always appends new children after old children, meanwhile, dom_avail_children (the original get_num_domains) only returns the number of valid sub-domains/targets, so it doesn't make sense to traverse, which is very expensive for large object. - Instead of checking bit by bit, tgt_isset_range and dom_isset_range can skip the entire byte of the bitmap if it is 0xFF. Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
|
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove _get_target and _get_dom, these function are not required. pool_map of DAOS can guarantee extension always appends new children after old children, meanwhile, dom_avail_children (the original get_num_domains) only returns the number of valid sub-domains/targets, so it doesn't make sense to traverse, which is very expensive for large object.
Instead of checking bit by bit, tgt_isset_range and dom_isset_range can skip the entire byte of the bitmap if it is 0xFF.
Steps for the author:
After all prior steps are complete: