DAOS-18495 md: 24k ABT stack size for md_on_ssd#17686
Conversation
|
Ticket title is 'Random ranks are excluded with signal (6) with master branch.' |
grom72
requested review from
NiuYawei and
kjacque
and removed request for
kjacque
Increase min ABT stack size to 24k for md_on_ssd Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2
Priority: 2 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
grom72
force-pushed
the
grom72/DAOS-18495-ABT_THREAD_STACKSIZE-24k-md-on-ssd
branch
from
6992eb3 to
71e9059
Compare
|
Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17686/2/testReport/ |
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17686/2/testReport/ |
Final implementation based on HasBdevRoleMeta(). Tests improvements. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Allow-unstable-test: true
|
Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17686/3/execution/node/1074/log |
| WithEnvVarAbtThreadStackSize(minABTThreadStackSizeMdOnSsd), | ||
| expABTthreadStackSize: minABTThreadStackSizeMdOnSsd, | ||
| }, | ||
| "config for md_on_ssd without thread size should sed ABT_THREAD_STACKSIZE": { |
tanabarr
left a comment
tanabarr
left a comment
There was a problem hiding this comment.
nonblocking suggestions, otherwise looks good
| t.Run(name, func(t *testing.T) { | ||
| err := tc.cfg.UpdateABTEnvarsMdOnSsd() | ||
| test.CmpErr(t, tc.expErr, err) | ||
| if err == nil { |
There was a problem hiding this comment.
return early if err != nil rather than nesting here
| err := tc.cfg.UpdateABTEnvarsMdOnSsd() | ||
| test.CmpErr(t, tc.expErr, err) | ||
| if err == nil { | ||
| if tc.expABTthreadStackSize == 0 { |
There was a problem hiding this comment.
nit: it would be tidier to run GetEnvVar before if check then perform checks on the result based on expected stack size after e.g. GetEnvVar; if expSS==0 {; Assert(err!=nil); return; }; <note no else clause> Assert(err==nil)....
Generally returning early where possible and reducing nesting to a minimum is seen as a good thing to improve readability of code in Go.
Only Unit Tests and NLT to be re-run to confirm that logic has not been changed. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Cancel-prev-build: false Skip-unit-test-memcheck: true Skip-test: true Skip-func-test: true Skip-func-vm: true Skip-func-hw-test: true
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com> Priority: 2 Allow-unstable-test: true
4 participants
Increase min ABT stack size to 24k for md_on_ssd
Steps for the author:
After all prior steps are complete: