Skip to content

DAOS-18673 pool: Initialize sp_recov_lock#17685

Draft
liw wants to merge 1 commit intomasterfrom
liw/fix-sp_recov_lock
Draft

DAOS-18673 pool: Initialize sp_recov_lock#17685
liw wants to merge 1 commit intomasterfrom
liw/fix-sp_recov_lock

Conversation

@liw
Copy link
Contributor

@liw liw commented Mar 11, 2026

Looks like ds_pool.sp_recov_lock is not initialized via ABT_rwlock_create. This led to the following ABT error,

#5  in ds_cont_tgt_open at src/container/srv_target.c:1954
#6  in cont_iv_ent_update at src/container/container_iv.c:646
#7  in update_iv_value at src/engine/server_iv.c:280
#8  in iv_on_update_internal at src/engine/server_iv.c:490
#9  in ivc_on_update at src/engine/server_iv.c:530
#10 in crt_iv_update_internal at src/cart/crt_iv.c:3438
#11 in crt_iv_update at src/cart/crt_iv.c:3559
#12 in iv_op_internal at src/engine/server_iv.c:1080
#13 in _iv_op at src/engine/server_iv.c:1129
#14 in iv_op at src/engine/server_iv.c:1241
#15 in ds_iv_update at src/engine/server_iv.c:1287
#16 in cont_iv_update at src/container/container_iv.c:867
#17 in cont_iv_capability_update at src/container/container_iv.c:1245
#18 in cont_open at src/container/srv_container.c:2821
#19 in cont_op_with_cont at src/container/srv_container.c:5613
#20 in cont_op_with_svc at src/container/srv_container.c:5845
#21 in ds_cont_op_handler at src/container/srv_container.c:6064
#22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108
#23 in crt_handle_rpc at src/cart/crt_rpc.c:1747

where the line was

#5  in ds_cont_tgt_open at src/container/srv_target.c:1954
1954            DABT_RWLOCK_RDLOCK(pool->sp_recov_lock);

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Ticket title is 'daos container query: ERROR: daos_engine:1 [rwlock.c:150] ABT_rwlock_rdlock: 23'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-18673

Looks like ds_pool.sp_recov_lock is not initialized via
ABT_rwlock_create. This led to the following ABT error,

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  #6  in cont_iv_ent_update at src/container/container_iv.c:646
  #7  in update_iv_value at src/engine/server_iv.c:280
  #8  in iv_on_update_internal at src/engine/server_iv.c:490
  #9  in ivc_on_update at src/engine/server_iv.c:530
  #10 in crt_iv_update_internal at src/cart/crt_iv.c:3438
  #11 in crt_iv_update at src/cart/crt_iv.c:3559
  #12 in iv_op_internal at src/engine/server_iv.c:1080
  #13 in _iv_op at src/engine/server_iv.c:1129
  #14 in iv_op at src/engine/server_iv.c:1241
  #15 in ds_iv_update at src/engine/server_iv.c:1287
  #16 in cont_iv_update at src/container/container_iv.c:867
  #17 in cont_iv_capability_update at src/container/container_iv.c:1245
  #18 in cont_open at src/container/srv_container.c:2821
  #19 in cont_op_with_cont at src/container/srv_container.c:5613
  #20 in cont_op_with_svc at src/container/srv_container.c:5845
  #21 in ds_cont_op_handler at src/container/srv_container.c:6064
  #22 in ds_cont_op_handler_v8 at src/container/srv_container.c:6108
  #23 in crt_handle_rpc at src/cart/crt_rpc.c:1747

where the line was

  #5  in ds_cont_tgt_open at src/container/srv_target.c:1954
  1954            DABT_RWLOCK_RDLOCK(pool->sp_recov_lock);

Signed-off-by: Li Wei <liwei@hpe.com>
@liw liw force-pushed the liw/fix-sp_recov_lock branch from 6103f56 to da151ae Compare March 11, 2026 03:10
@liw liw requested review from Nasf-Fan and liuxuezhao March 11, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants