Skip to content

DAOS-18598 vos: Skip reserving check for EC agg#17664

Open
NiuYawei wants to merge 1 commit intomasterfrom
niu/DAOS-18598
Open

DAOS-18598 vos: Skip reserving check for EC agg#17664
NiuYawei wants to merge 1 commit intomasterfrom
niu/DAOS-18598

Conversation

@NiuYawei
Copy link
Contributor

@NiuYawei NiuYawei commented Mar 9, 2026

  • Skip space reserving check for EC aggregation.
  • Handle removal properly in space reserving check.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@NiuYawei
DAOS-18598 vos: Skip reserving check for EC agg
98dd8f7 
- Skip space reserving check for EC aggregation.
- Handle removal properly in space reserving check.

Signed-off-by: Niu Yawei <yawei.niu@hpe.com>
@NiuYawei NiuYawei requested review from a team as code owners March 9, 2026 03:24
@NiuYawei NiuYawei requested review from Nasf-Fan and liuxuezhao and removed request for a team March 9, 2026 03:24
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Ticket title is 'Aurora daos_user: Need some information on how space_rb is getting calculated and what will be the impact if it changed in between'
Status is 'Open'
Labels: 'ALCF'
https://daosio.atlassian.net/browse/DAOS-18598

liuxuezhao
liuxuezhao approved these changes Mar 9, 2026
View reviewed changes
src/object/srv_ec_aggregate.c
entry->ae_cur_stripe.as_hi_epoch, 0, 0,
&entry->ae_dkey, 1, iod,
stripe_ud.asu_iod_csums,
entry->ae_cur_stripe.as_hi_epoch, 0, VOS_OF_CRIT,
Copy link
Contributor

@liuxuezhao liuxuezhao Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirm that why without VOS_OF_REBUILD flag same as the EC AGG RPC handler?

Copy link
Contributor

@liuxuezhao liuxuezhao Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to keep the code as this, thanks.

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Mar 9, 2026

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17664/1/execution/node/1321/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Mar 11, 2026

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17664/2/execution/node/429/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NiuYawei @daosbuild3 @liuxuezhao @Nasf-Fan