Conversation
tsses() -> gffutils.pybedtools_integration.tsses()
the refactor makes it a bit easier to read, simplifies some operations, and supports the new "semicolon in quotes" dialect entry
this just copies the docstrings across parents and children rather than trying to generalize with _relations() docstring.
- fix version parsing (setuptools was fixing it anyway, but better to do it ahead of time) - rm OSI license classifier as recommended by setuptools
- remove vestiges of mamba - install via pyproject.toml - create docs with latest tested version of python - rm py3.8 and py3.9 support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From changelog:
semicolon in quotes, and running the necessary regular expression only when inferring dialect, or, ifsemicolon in quotesisTrue, on every feature. In the latter case, this can dramatically increase the parsing time, since in Python regular expressions are relatively slow, but it does correctly parse. Thanks to @DevangThakkar for the fix.orderkey of dialects would list the repeated keys each time they appeared (i.e., the list had duplicates) which could result in undetermined behavior. Theorderkey is now unique and only the first occurrence of a repeated key will be added to the order.ensembl_gtf.txtexample file had a leading space in front of the attributes. This looks to be an error in the creation of the example file in the first place, but had previously parsed fine. Now the parser (correctly) mis-handles it. Since I'm unaware of any cases in the wild that have a leading space, I actually consider the new parsing, which complains about the space, to be more correct.create_db()imports from a file path, matching the behavior for string-backed iterators and fixing #213. This was due to a different path through the code when using apathlib.Pathobject. In addition to this fix,pathlib.Pathobjects are now converted tostrthroughout the code base withos.fspathwhere appropriate.arghpackage used for the command-line tool.pyproject.tomlfor packaging. This changes how versions are calculated and reported, and removes the need forsetup.py. Version is only ever recorded inpyproject.toml;version.pygets the installed version or parses the TOML if not installed;setup.pyjust callssetup()with no arguments since everything has been migrated topyproject.toml.