Skip to content

fix(shared): prevent install extension prompt flicker#5690

Merged
rebelchris merged 3 commits intomainfrom
eng-1009-disabled-install-extension-experiment-flickers-on-open
Mar 10, 2026
Merged

fix(shared): prevent install extension prompt flicker#5690
rebelchris merged 3 commits intomainfrom
eng-1009-disabled-install-extension-experiment-flickers-on-open

Conversation

@rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Mar 10, 2026

Summary

  • gate the install-extension CTA on isActionsFetched so dismissed prompts stay hidden until actions are loaded
  • add a focused regression spec for the loading, dismissed, and visible states
  • keep the implementation minimal and align it with the existing action-gating pattern already used in shared components

Key Decisions

  • use the existing isActionsFetched signal instead of adding a new loading state or delaying the experiment evaluation
  • keep the fix local to SearchControlHeader and verify only the impacted shared files

Closes ENG-1009


Created by Huginn 🐦‍⬛

Preview domain

https://eng-1009-disabled-install-extens.preview.app.daily.dev

@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Mar 10, 2026 11:17am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Mar 10, 2026 11:17am

Request Review

@rebelchris rebelchris merged commit 22d06ec into main Mar 10, 2026
11 checks passed
@rebelchris rebelchris deleted the eng-1009-disabled-install-extension-experiment-flickers-on-open branch March 10, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant