fix: py3.14: secrets: list[str] TypeError FunctionWithAio#154
Merged
markbackman merged 1 commit intodaily-co:mainfrom Apr 2, 2026
Merged
fix: py3.14: secrets: list[str] TypeError FunctionWithAio#154markbackman merged 1 commit intodaily-co:mainfrom
markbackman merged 1 commit intodaily-co:mainfrom
Conversation
Python 3.14 defers evaluation of list[str] by wrapping it in __annotate__. Fix by using explicit typing.List hint. Signed-off-by: Ed Swarthout <Ed.Swarthout58@gmail.com>
markbackman
approved these changes
Apr 2, 2026
Contributor
markbackman
left a comment
markbackman
left a comment
There was a problem hiding this comment.
Thanks for catching this and proposing the fix 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 defers evaluation of
list[str]by wrapping it in__annotate__.Fix by using explicit
typing.Listhint.py3.14 annotations