Update to purge functionality (D832)#607
Open
droberts-ctrlo wants to merge 2 commits intoctrlo:devfrom
Open
Conversation
Specific datum changes are present as not every datum is purgeable. The system will now mark the record as purged and disallow editing, putting the record into an archived state. Further discussion may be required as to whether to mark the record as archived within the table as it is displayed as well as current (new) functionality to show the record as archived once the record is opened.
droberts-ctrlo
changed the title
pwlodarski-ctrlo
left a comment
pwlodarski-ctrlo
left a comment
There was a problem hiding this comment.
Overall looks good - just one or two clarity comments.
| name => $old_name | ||
| })->next) { | ||
| $changed = 0 if $fl && $fl->content eq $old_content; | ||
| # Fix - if the data is originally purged, then the fileval record will have been deleted, so we need to account for that |
There was a problem hiding this comment.
Is this a 'Need Fixing' reminder, or is that a comment to exclaim a fix has been made?
| my @presentation_columns = $self->presentation_map_columns(%options, columns => \@columns); | ||
| my @topics= $self->get_topics(\@presentation_columns); | ||
|
|
||
| my $has_purged = !!(grep { defined $_->{data}->{purged} && $_->{data}->{purged} } map { @{$_->{columns}} } @topics); |
There was a problem hiding this comment.
Could this be potentially a multi-line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specific datum changes are present, as not every datum is purgeable. The system will now mark the record as purged and disallow editing, putting the record into an archived state.
Further discussion may be required as to whether to mark the record as archived within the table as it is displayed as well as current (new) functionality to show the record as archived once the record is opened.