Better 2D Curvilinear Operators (MATLAB)#312
Draft
bewagner1 wants to merge 6 commits intocsrc-sdsu:mainfrom
Draft
Better 2D Curvilinear Operators (MATLAB)#312bewagner1 wants to merge 6 commits intocsrc-sdsu:mainfrom
bewagner1 wants to merge 6 commits intocsrc-sdsu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The current curvilinear operators have some issues.
DI2andGI2functions)This new implementation alleviates those issues, but still raises some of its own. These operators output to or act on the "extended" faces. These are the normal faces, plus the boundaries (see below).
Related Issues & Documents
QA Instructions, Screenshots, Recordings
Run the file
curvConvergenceTest.minexamples/matlab_octave.Added/updated tests?
have not been included
Read Contributing Guide and Code of Conduct
[optional] Are there any post deployment tasks we need to perform?
Update documentation (re the "extended" faces)
[optional] What gif best describes this PR or how it makes you feel?