Skip to content

Better 2D Curvilinear Operators (MATLAB)#312

Draft
bewagner1 wants to merge 6 commits intocsrc-sdsu:mainfrom
bewagner1:bpw_curv2D
Draft

Better 2D Curvilinear Operators (MATLAB)#312
bewagner1 wants to merge 6 commits intocsrc-sdsu:mainfrom
bewagner1:bpw_curv2D

Conversation

@bewagner1
Copy link
Copy Markdown
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Example
  • Documentation

Description

The current curvilinear operators have some issues.

  • They use MATLAB interpolators, which are only 2nd order.
  • They cannot handle periodic domains
  • Their implementation does not follow what is outlined in the documentation very closely (nodal Jacobian)
  • Their implementation is hard to follow (DI2 and GI2 functions)
  • Their accuracy doesn't really change with k and don't have _k_th order accuracy

This new implementation alleviates those issues, but still raises some of its own. These operators output to or act on the "extended" faces. These are the normal faces, plus the boundaries (see below).

Grad-Shafranov 4

Related Issues & Documents

  • I have created an Issue that is paired with this PR

QA Instructions, Screenshots, Recordings

Run the file curvConvergenceTest.m in examples/matlab_octave.

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Read Contributing Guide and Code of Conduct

[optional] Are there any post deployment tasks we need to perform?

Update documentation (re the "extended" faces)

[optional] What gif best describes this PR or how it makes you feel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant