fix(rpc): Fix eth_getBlockReceipts crash when KV indexer is overwritten

[JayT106]

eth_getBlockReceipts (and eth_getTransactionReceipt with an explicit block scope) could crash or return a receipt from the wrong block when the KV tx indexer had been overwritten to point the same Ethereum tx hash at a later block height.

Changes

• GetBlockReceipts – skip nil receipts instead of panicking on append
• GetTransactionReceipt – compare indexer-reported height against the caller-supplied resBlock height; when they differ, rebuild the TxResult from the requested block's data rather than trusting the stale index
• txResultFromBlockHash (new helper) – walks all transactions in a ResultBlock, parses each via ParseTxResult, and returns a correctly-anchored TxResult + ResultBlockResults for the requested block; returns (nil, blockRes, nil) when the hash is not present in the block

// Before: blockRes always fetched from indexer height (wrong block if index was overwritten)
blockRes, err := b.TendermintBlockResultByNumber(&res.Height)

// After: if indexer height ≠ requested block height, rescan the requested block
if res.Height == resBlock.Block.Height {
    blockRes, err = b.TendermintBlockResultByNumber(&res.Height)
} else {
    res, blockRes, err = b.txResultFromBlockHash(resBlock, hash)
}

• Tests – added TestGetTransactionReceipt_BlockScopedWhenIndexerOverwritten covering the full overwrite scenario: index two blocks for the same tx hash, verify block-scoped queries return data anchored to the requested block

[codecov]

Codecov Report

❌ Patch coverage is 54.00000% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.11%. Comparing base (620d74d) to head (742830c).

Files with missing lines	Patch %	Lines
rpc/backend/tx_info.go	56.25%	12 Missing and 9 partials ⚠️
rpc/backend/blocks.go	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #877      +/-   ##
===========================================
+ Coverage    43.07%   43.11%   +0.03%     
===========================================
  Files          195      195              
  Lines        16551    16597      +46     
===========================================
+ Hits          7130     7156      +26     
- Misses        8697     8708      +11     
- Partials       724      733       +9     

Files with missing lines	Coverage Δ
rpc/backend/blocks.go	78.86% <0.00%> (-0.48%)	⬇️
rpc/backend/tx_info.go	54.80% <56.25%> (+0.60%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[songgaoye]

LGTM

[thomas-nguy]

Change the implementation to return the receipt in the block

[JayT106]

Change the implementation to return the receipt in the block

Done!

[thomas-nguy]

@copilot review the PR

[Copilot]

@copilot review the PR

PR review completed. The implementation looks correct and the tests pass. Here's a summary:

Changes reviewed:

• blocks.go – GetBlockReceipts now skips nil receipts with continue to prevent panics.
• tx_info.go – GetTransactionReceipt compares the indexer height (res.Height) against the requested block height (resBlock.Block.Height). When they differ (indexer overwrite scenario), it calls the new txResultFromBlockHash helper to rebuild the TxResult from the requested block's transactions instead of returning the wrong block's data.
• txResultFromBlockHash – Scans all txs in the requested block, parses each one via ParseTxResult, and returns a correctly-anchored TxResult + ResultBlockResults for the requested block. Returns (nil, blockRes, nil) when the hash isn't found in the block (handled gracefully by the caller).

No issues found. Edge cases are handled (out-of-range indexes, decode errors, tx not found in block). All related tests pass (commit a6b75e5).

[songgaoye]

just need to fix the nil guard. LGTM