fix reconnection in boost::asio code#548
Merged
cryptochassis merged 1 commit intocrypto-chassis:developfrom Sep 23, 2025
Merged
fix reconnection in boost::asio code#548cryptochassis merged 1 commit intocrypto-chassis:developfrom
cryptochassis merged 1 commit intocrypto-chassis:developfrom
Conversation
| } else if (kind == boost::beast::websocket::frame_type::pong) { | ||
| this->onPong(wsConnectionPtr, payload); | ||
| } else if (kind == boost::beast::websocket::frame_type::close) { | ||
| this->onClose(wsConnectionPtr, {}); |
Contributor
There was a problem hiding this comment.
@fedeitc I think we should leave this line there, should we?
Collaborator
Author
There was a problem hiding this comment.
No, it should be removed.
The control_callback is always triggered during a read operation, so there will always be a subsequent call to onReadWs after the control_callback, with the error_code set.
Invoking onClose at this point would result in a double reconnection attempt, the first from onClose and then again from onFail via onReadWs.
https://www.boost.org/doc/libs/1_87_0/libs/beast/doc/html/beast/ref/boost__beast__websocket__stream/async_read.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.