Skip to content
This repository was archived by the owner on Aug 16, 2022. It is now read-only.

WIP: ✨ Initialize blog app#36

Open
SukiCZ wants to merge 1 commit intomasterfrom
feature/blog
Open

WIP: ✨ Initialize blog app#36
SukiCZ wants to merge 1 commit intomasterfrom
feature/blog

Conversation

@SukiCZ
Copy link
Collaborator

@SukiCZ SukiCZ commented Jun 15, 2021

TODO:

  • whitelist for users
  • unit-tests

@SukiCZ SukiCZ requested a review from RiccardoBiosas June 15, 2021 19:24
@SukiCZ SukiCZ self-assigned this Jun 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #36 (44fd51b) into master (77aa653) will decrease coverage by 1.42%.
The diff coverage is 77.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   87.42%   86.00%   -1.43%     
==========================================
  Files          18       23       +5     
  Lines         660      750      +90     
  Branches       60       66       +6     
==========================================
+ Hits          577      645      +68     
- Misses         68       90      +22     
  Partials       15       15              
Impacted Files Coverage Δ
blog/serializers.py 53.33% <53.33%> (ø)
blog/view_sets.py 71.42% <71.42%> (ø)
blog/models.py 90.00% <90.00%> (ø)
ad_source/managers.py 94.11% <100.00%> (+0.78%) ⬆️
ad_source/models.py 97.46% <100.00%> (ø)
ad_source/serializers.py 94.28% <100.00%> (+0.16%) ⬆️
ad_source/tasks.py 36.53% <100.00%> (ø)
ad_source/view_sets.py 95.95% <100.00%> (ø)
blog/admin.py 100.00% <100.00%> (ø)
blog/apps.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4dba8...44fd51b. Read the comment docs.

Copy link
Member

@RiccardoBiosas RiccardoBiosas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now every authenticated user is an author and there are no 'whitelisted' public keys/users, right?

@SukiCZ
Copy link
Collaborator Author

SukiCZ commented Jun 17, 2021

right now every authenticated user is an author and there are no 'whitelisted' public keys/users, right?

@RiccardoBiosas I knew I forgot something. to be more clear only those who create author "profile" can create articles. adding whitelist to TODOs 👌🏿

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants