Skip to content

Replace full alloy import with specific alloy crates#4219

Merged
jmg-duarte merged 3 commits intomainfrom
jmgd/deps/untangle-primitives
Mar 2, 2026
Merged

Replace full alloy import with specific alloy crates#4219
jmg-duarte merged 3 commits intomainfrom
jmgd/deps/untangle-primitives

Conversation

@jmg-duarte
Copy link
Contributor

Description

Based on @MartinquaXD's comment on Slack, I figured that there would be places where we can import the specific alloy crate, unlocking earlier and more parallel compilation. These changes alone seem to save ~5s on a clean build in my laptop; going down from ~1m to 55s.

There's more gains to take from this, but for that we need to separate shared further and then split those dependencies. #4217 would also help a bunch.

Changes

  • app-data
    • replace alloy with alloy-primitives
    • since alloy uses tiny-keccak, replace the tiny-keccak with alloy's keccak
  • chain
    • manually implement thiserror (less 1 dep)
    • replace alloy with alloy-primitives
  • model
    • replace alloy with alloy-primives, alloy-signer, alloy-signer-local, alloy-sol-types
  • number
    • replace alloy with alloy-primitives
  • order-validation
    • replace alloy with alloy-primitives and alloy-contract
    • remove thiserror wrapper (less 1 dep)
  • serde-ext
    • replace alloy with alloy-primitives
  • testlib
    • replace alloy with alloy-primitives
  • winner-selection
    • replace alloy with alloy-primitives

How to test

Compiler + existing tests

@jmg-duarte jmg-duarte requested a review from a team as a code owner March 1, 2026 14:12
gemini-code-assist[bot]

This comment was marked as resolved.

@jmg-duarte jmg-duarte force-pushed the jmgd/deps/untangle-primitives branch from e3bca69 to 7a10643 Compare March 1, 2026 15:20
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. 👍

@jmg-duarte jmg-duarte enabled auto-merge March 2, 2026 09:43
@jmg-duarte jmg-duarte added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 5cd893e Mar 2, 2026
19 checks passed
@jmg-duarte jmg-duarte deleted the jmgd/deps/untangle-primitives branch March 2, 2026 10:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants