Skip to content

Update partner-fee.md#589

Merged
harisang merged 2 commits intomainfrom
paulafgtorres-patch-1
Mar 4, 2026
Merged

Update partner-fee.md#589
harisang merged 2 commits intomainfrom
paulafgtorres-patch-1

Conversation

@paulafgtorres
Copy link
Contributor

@paulafgtorres paulafgtorres commented Jan 29, 2026

Updating Partner Fee as requested, please let me know if there is anything else that needs to be changed :)

Description

Changes

  • Changed old CIP to new CIP-75, fee from 50% to 25%
  • Added "or API integration"

Summary by CodeRabbit

  • Documentation
    • Partner Fee now applies to trades executed via Widget or API integrations (previously Widget only)
    • Default service fee reduced from 50% to 25% of total eligible Partner Fee
    • Governance reference updated from CIP-61 to CIP-75
    • Clarified eligibility, payment workflow, recipient determination, and partner data processing for weekly transfers

@paulafgtorres paulafgtorres requested a review from a team as a code owner January 29, 2026 11:02
@vercel
Copy link

vercel bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Mar 4, 2026 10:15am

Request Review

@github-actions
Copy link

github-actions bot commented Jan 29, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (harisang)[https://github.com/harisang]
@paulafgtorres
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f106addb-13b6-43d8-a775-0646abc4a525

📥 Commits

Reviewing files that changed from the base of the PR and between 1d247ff and b1908eb.

📒 Files selected for processing (1)
  • docs/governance/fees/partner-fee.md
 ______________________________
< Carpe Debug. Seize the bugs. >
 ------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

✏️ Tip: You can disable in-progress messages and the fortune message in your review settings.

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

📝 Walkthrough

Walkthrough

The pull request updates partner fee documentation to reference CIP-75 instead of CIP-61, reduces the default service fee from 50% to 25%, and expands Partner Fee applicability to include both Widget and API integrations in addition to clarifying related payment processes.

Changes

Cohort / File(s) Summary
Partner Fee Documentation
docs/governance/fees/partner-fee.md
Updated CIP reference (CIP-61 → CIP-75), reduced default service fee (50% → 25%), expanded applicability from Widget-only to Widget and API integrations, and clarified payment workflow and eligibility language.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop, our fees take a spin,
API and Widget share the win,
From fifty to twenty-five we descend,
New CIP reference, a partner's best friend!
Documentation updated with grace,
More integrations, a wider embrace! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is overly vague and generic; it describes what file was updated but fails to convey the specific, meaningful changes (CIP reference update, fee reduction, API integration expansion). Consider using a more descriptive title that captures the main changes, such as 'Update partner fee structure: CIP-75, reduce service fee to 25%, add API integration'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the required Description and Changes sections with concrete details about the modifications, though it could be more formal and structured.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch paulafgtorres-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@docs/governance/fees/partner-fee.md`:
- Around line 72-74: Update the wording so all three bullets consistently state
that both Widget and API integrations are included: change the second bullet's
"Widget integration" to "Widget or API integration" and the third bullet's
"Widget" to "Widget or API integration" (references: "Partner Fee parameters",
"appData", and the Partner Fee 'Recipient' parameter) so the data script and
weekly transfer clearly apply to trades via either integration.
🧹 Nitpick comments (1)
docs/governance/fees/partner-fee.md (1)

20-20: Clarify if the 100 BPS limit applies to API integrations.

Since the Partner Fee scope has been expanded to include API integrations (lines 22, 72), consider clarifying whether the 100 BPS limit also applies to API integrations or if it remains Widget-specific.

📝 Suggested update if the limit applies to both Widget and API
-You may charge users a fee of no more than 100 bps of order volume through your Widget. 
+You may charge users a fee of no more than 100 bps of order volume through your Widget or API integration.

@harisang
Copy link
Contributor

harisang commented Feb 2, 2026

@paulafgtorres i think for first-time contributors, you just need to post a comment in this PR with the msg

I have read the CLA Document and I hereby sign the CLA

as mentioned here.

paulafgtorres and others added 2 commits March 4, 2026 12:13
Updating Partner Fee as requested, please let me know if there is anything else that needs to be changed :)
@harisang
Copy link
Contributor

harisang commented Mar 4, 2026

taking the liberty to merge this as it is long overdue

@harisang harisang merged commit 90a6498 into main Mar 4, 2026
3 of 5 checks passed
@harisang harisang deleted the paulafgtorres-patch-1 branch March 4, 2026 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants