Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✏️ Tip: You can disable in-progress messages and the fortune message in your review settings. Tip CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.OpenGrep is compatible with Semgrep configurations. Add an 📝 WalkthroughWalkthroughThe pull request updates partner fee documentation to reference CIP-75 instead of CIP-61, reduces the default service fee from 50% to 25%, and expands Partner Fee applicability to include both Widget and API integrations in addition to clarifying related payment processes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/governance/fees/partner-fee.md`:
- Around line 72-74: Update the wording so all three bullets consistently state
that both Widget and API integrations are included: change the second bullet's
"Widget integration" to "Widget or API integration" and the third bullet's
"Widget" to "Widget or API integration" (references: "Partner Fee parameters",
"appData", and the Partner Fee 'Recipient' parameter) so the data script and
weekly transfer clearly apply to trades via either integration.
🧹 Nitpick comments (1)
docs/governance/fees/partner-fee.md (1)
20-20: Clarify if the 100 BPS limit applies to API integrations.Since the Partner Fee scope has been expanded to include API integrations (lines 22, 72), consider clarifying whether the 100 BPS limit also applies to API integrations or if it remains Widget-specific.
📝 Suggested update if the limit applies to both Widget and API
-You may charge users a fee of no more than 100 bps of order volume through your Widget. +You may charge users a fee of no more than 100 bps of order volume through your Widget or API integration.
|
@paulafgtorres i think for first-time contributors, you just need to post a comment in this PR with the msg
as mentioned here. |
Updating Partner Fee as requested, please let me know if there is anything else that needs to be changed :)
1d247ff to
b1908eb
Compare
|
taking the liberty to merge this as it is long overdue |
Updating Partner Fee as requested, please let me know if there is anything else that needs to be changed :)
Description
Changes
Summary by CodeRabbit