fix(toast-load): infinite load of adding a card on a collection page#704
Open
tylersayshi wants to merge 1 commit intocosmik-network:mainfrom
Open
fix(toast-load): infinite load of adding a card on a collection page#704tylersayshi wants to merge 1 commit intocosmik-network:mainfrom
tylersayshi wants to merge 1 commit intocosmik-network:mainfrom
Conversation
Adding a card from a collection page shows 'Adding card...' forever. The collection page's `<Suspense>` boundary re-suspends on query invalidation, unmounting the component before React Query can fire the mutate-level `onSuccess`/`onError` callbacks that update the toast. Moved toast handling from mutate-level callbacks into definition-level callbacks on `useMutation`, which always fire regardless of component mount state.
|
@tylersayshi is attempting to deploy a commit to the Cosmik Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
some js lib tool notes as an aside (feel free to disregard):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a card from a collection page shows 'Adding card...' forever. The collection page's
<Suspense>boundary re-suspends on query invalidation, unmounting the component before.React Query can fire the mutate-level
onSuccess/onErrorcallbacks that update the toast. This PR moves toast handling from mutate-level callbacks into definition-level callbacks onuseMutation, which always fire regardless of component mount state.I updated the docs and iframely service a bit from dev'ing on this as someone without any secrets or desire to fully run the backend.
thanks again for semble! this stuff is awesome.