Add notes of caution about sideEffects key in package.json#2
Open
KonnorRogers wants to merge 2 commits intocoryrylan:mainfrom
Open
Add notes of caution about sideEffects key in package.json#2KonnorRogers wants to merge 2 commits intocoryrylan:mainfrom
sideEffects key in package.json#2KonnorRogers wants to merge 2 commits intocoryrylan:mainfrom
Conversation
Hi there! I stumbled on your guide today on Bluesky and noticed the note about "sideEffects". While it currently says its "needed", im here to provide some feedback on how `sideEffects` has burned me. Feel free to close, but heres a blog post I made with some links to various broken packages as a result of using the `sideEffects` key. https://www.konnorrogers.com/posts/2023/the-shoelace-side-effect-scavenger-hunt ( you can ignore everything after the linked github issues)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! I stumbled on your guide today on Bluesky and noticed the note about "sideEffects". While it currently says its "needed", im here to provide some feedback on how
sideEffectshas burned me. Feel free to close, but heres a blog post I made with some links to various broken packages as a result of using thesideEffectskey.https://www.konnorrogers.com/posts/2023/the-shoelace-side-effect-scavenger-hunt
( you can ignore everything after the linked github issues)