Skip to content

Enable HATracker memberlist#7284

Merged
SungJin1212 merged 5 commits intocortexproject:masterfrom
SungJin1212:Enable-HATracker-memberlist
Mar 10, 2026
Merged

Enable HATracker memberlist#7284
SungJin1212 merged 5 commits intocortexproject:masterfrom
SungJin1212:Enable-HATracker-memberlist

Conversation

@SungJin1212
Copy link
Member

This PR enables memberlist on HATracker.
It includes the implementations of a mergeable interface of ReplicaDesc.

Which issue(s) this PR fixes:
Fixes #7220

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212
Copy link
Member Author

@yeya24
I updated the PR.
To allow for zero-downtime migrations when moving from consul/etcd to memberlist, I also included the multi.

@SungJin1212 SungJin1212 force-pushed the Enable-HATracker-memberlist branch from 0a901c6 to b958c62 Compare February 25, 2026 05:03
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

friedrichg
friedrichg previously approved these changes Feb 26, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2026
@SungJin1212 SungJin1212 force-pushed the Enable-HATracker-memberlist branch 2 times, most recently from 22d08cc to 68989ae Compare February 27, 2026 11:05
@SungJin1212
Copy link
Member Author

@friedrichg
Could you review the Merge function again? I changed it to meet the commutative law.

@friedrichg friedrichg dismissed their stale review March 4, 2026 09:50

I think this not ready yet.

See #7324
see this commit cc52a02

@SungJin1212 SungJin1212 force-pushed the Enable-HATracker-memberlist branch from bade89c to 04f6b06 Compare March 5, 2026 07:32
@SungJin1212 SungJin1212 force-pushed the Enable-HATracker-memberlist branch 3 times, most recently from 3a0900b to 3276e1c Compare March 5, 2026 10:51
@SungJin1212 SungJin1212 requested a review from friedrichg March 5, 2026 11:49
@friedrichg friedrichg mentioned this pull request Mar 9, 2026
3 tasks
Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the Enable-HATracker-memberlist branch from 9fcdf08 to ab2e8a7 Compare March 10, 2026 01:38
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the Enable-HATracker-memberlist branch from ab2e8a7 to b69e502 Compare March 10, 2026 02:12
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the Enable-HATracker-memberlist branch from ca07242 to 7f2e015 Compare March 10, 2026 03:04
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 requested a review from friedrichg March 10, 2026 04:50
@SungJin1212 SungJin1212 merged commit f1b0c35 into cortexproject:master Mar 10, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ha-tracker lgtm This PR has been approved by a maintainer size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Memberlist as valid HA-tracker store

3 participants