Skip to content

Only do 5 calls to the openalex API at a time #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odarbelaeze merged 1 commit into from
Feb 3, 2025
Merged

Only do 5 calls to the openalex API at a time #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/bibx/clients/openalex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@

logger = logging.getLogger(__name__)

MAX_WORKS_PER_PAGE = 200
MAX_IDS_PER_REQUEST = 80
_MAX_WORKS_PER_PAGE = 200
_MAX_IDS_PER_REQUEST = 80
_MAX_CONNECTIONS = 5


class AuthorPosition(Enum):
Expand Down Expand Up @@ -145,17 +146,17 @@ def list_recent_articles(self, query: str, limit: int = 600) -> list[Work]:
"cited_by_count:>1",
]
)
pages = (limit // MAX_WORKS_PER_PAGE) + 1
pages = (limit // _MAX_WORKS_PER_PAGE) + 1
results: list[Work] = []
with ThreadPoolExecutor(max_workers=min(pages, 25)) as executor:
with ThreadPoolExecutor(max_workers=min(pages, _MAX_CONNECTIONS)) as executor:
futures = [
executor.submit(
self._fetch_works,
{
"select": select,
"filter": filter_,
"sort": "publication_year:desc",
"per_page": MAX_WORKS_PER_PAGE,
"per_page": _MAX_WORKS_PER_PAGE,
"page": page,
},
)
Expand All @@ -175,17 +176,17 @@ def list_articles_by_openalex_id(self, ids: list[str]) -> list[Work]:
return []
select = ",".join(Work.model_fields.keys())
results: list[Work] = []
with ThreadPoolExecutor(max_workers=5) as executor:
with ThreadPoolExecutor(max_workers=_MAX_CONNECTIONS) as executor:
futures = [
executor.submit(
self._fetch_works,
{
"select": select,
"filter": f"ids.openalex:{'|'.join(ids)},type:types/article",
"per_page": MAX_IDS_PER_REQUEST,
"per_page": _MAX_IDS_PER_REQUEST,
},
)
for ids in chunks(ids, MAX_IDS_PER_REQUEST)
for ids in chunks(ids, _MAX_IDS_PER_REQUEST)
]
for future in as_completed(futures):
work_response = future.result()
Expand Down