Skip to content

Fix inconsistencies between --all and --filter=all in volume prune#28464

Open
simonbrauner wants to merge 1 commit intocontainers:mainfrom
simonbrauner:volume-prune-fix-all-filter
Open

Fix inconsistencies between --all and --filter=all in volume prune#28464
simonbrauner wants to merge 1 commit intocontainers:mainfrom
simonbrauner:volume-prune-fix-all-filter

Conversation

@simonbrauner
Copy link
Copy Markdown
Contributor

@simonbrauner simonbrauner commented Apr 8, 2026

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

The `volume prune` options `--all` and `--filter=all` no longer has different behavior.

@simonbrauner simonbrauner force-pushed the volume-prune-fix-all-filter branch from b285a93 to d21762f Compare April 8, 2026 11:15
@packit-as-a-service
Copy link
Copy Markdown

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@simonbrauner simonbrauner force-pushed the volume-prune-fix-all-filter branch 5 times, most recently from e7c7fad to 4a233d7 Compare April 8, 2026 11:40
@simonbrauner
Copy link
Copy Markdown
Contributor Author

While working on #28413, I found out that podman volume prune --filter=all=true outputs Error: "all" is an invalid volume filter, while podman volume prune --all=true does not, but according to the documentation, these options should be equivalent

@simonbrauner simonbrauner force-pushed the volume-prune-fix-all-filter branch 2 times, most recently from e4a5e9f to 8be1134 Compare April 8, 2026 12:51
Signed-off-by: Šimon Brauner <sbrauner@redhat.com>
@simonbrauner simonbrauner force-pushed the volume-prune-fix-all-filter branch from 8be1134 to 4f252be Compare April 8, 2026 12:52
Copy link
Copy Markdown
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@simonbrauner simonbrauner marked this pull request as ready for review April 8, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants