two small review fixes from storage.conf rework#28348
Merged
mheon merged 2 commits intocontainers:mainfrom Mar 23, 2026
Merged
Conversation
We do not want to bind mount storage.conf anymore. Generally a podman with old config should work with the upgrade to new podman with new config. The old podman with new config however may not work as such we should not make them use the same config. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Per new config file parsing order the /etc/containers/storage.conf path we create below is a clean overwrite so there is no need to explicitly remove the file here. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
|
LGTM |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small follow fixes as pointed out by @mtrmac in #28194
Does this PR introduce a user-facing change?