Skip to content

Remove slirp for Podman6#6443

Draft
lsm5 wants to merge 4 commits intocontainers:mainfrom
lsm5:podman6-no-slirp
Draft

Remove slirp for Podman6#6443
lsm5 wants to merge 4 commits intocontainers:mainfrom
lsm5:podman6-no-slirp

Conversation

@lsm5
Copy link
Copy Markdown
Member

@lsm5 lsm5 commented Oct 21, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

For podman6

How to verify it

Verify buildah doesn't work with slirp

Which issue(s) this PR fixes:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Slirp4netns support has been removed.

Rebased on the cgroups v1 removal PR.

@lsm5 lsm5 added the podman 6 breaking changes that should only go into podman 6 label Oct 21, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5 lsm5 force-pushed the podman6-no-slirp branch from c0c824d to d14aa61 Compare October 21, 2025 16:01
@packit-as-a-service
Copy link
Copy Markdown

packit-as-a-service bot commented Oct 21, 2025

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5 lsm5 force-pushed the podman6-no-slirp branch from d14aa61 to 9374d7f Compare October 21, 2025 18:11
@nalind
Copy link
Copy Markdown
Member

nalind commented Oct 22, 2025

Does this include the changes from #6424?

@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Oct 23, 2025

Does this include the changes from #6424?

I think so. I might need to rebase on main though. Also, one of the crun tests timed out. I retriggered it just now.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025
@openshift-merge-robot
Copy link
Copy Markdown
Collaborator

openshift-merge-robot commented Oct 24, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

TomSweeneyRedHat commented Nov 18, 2025

@lsm needs rebasing

@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Nov 19, 2025

@lsm needs rebasing

@TomSweeneyRedHat lsm is someone else (and he liked the comment 😄) . Might wanna wait for the suggestions when you start @-ing

@TomSweeneyRedHat
Copy link
Copy Markdown
Member

TomSweeneyRedHat commented Nov 19, 2025

@lsm5 I can not be held legally responsible for anything that I type before 9:00 in the morning or after 5:00 in the afternoon my time.

@lsm, apologies for the noise!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 20, 2025

A friendly reminder that this PR had no activity for 30 days.

@lsm5
vendor update
0115dd2 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5 lsm5 force-pushed the podman6-no-slirp branch from 9374d7f to 7bf5751 Compare April 6, 2026 16:55
nalind
nalind reviewed Apr 6, 2026
View reviewed changes
internal/mkcw/embed/entrypoint_amd64.gz
Copy link
Copy Markdown
Member

@nalind nalind Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file's removal appears to be unintended.

Copy link
Copy Markdown
Member Author

@lsm5 lsm5 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get this one going: #6736

run_common.go Outdated
if ns := options.NamespaceOptions.Find(string(specs.NetworkNamespace)); ns == nil {
if _, err := exec.LookPath("slirp4netns"); err != nil {
// if slirp4netns is not installed we have to use the hosts net namespace
if _, err := exec.LookPath("passt"); err != nil {
Copy link
Copy Markdown
Member

@nalind nalind Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we invoke pasta, don't we?

Copy link
Copy Markdown
Member Author

@lsm5 lsm5 Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Thanks.

@lsm5 lsm5 mentioned this pull request Apr 6, 2026
Draft
6 tasks
lsm5 added 3 commits April 6, 2026 13:46
@lsm5
Remove slirp for podman6
f7a655f 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
tests: Remove slirp for podman6
d8d07da 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
docs: Remove slirp for podman6
a5edbae 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5 lsm5 force-pushed the podman6-no-slirp branch from 7bf5751 to a5edbae Compare April 6, 2026 17:46
@lsm5
Copy link
Copy Markdown
Member Author

lsm5 commented Apr 6, 2026

This will stay in draft until containers/container-libs#393 and containers/podman#28451 are sane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nalind nalind nalind left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

approved do-not-merge/work-in-progress needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. podman 6 breaking changes that should only go into podman 6 stale-pr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lsm5 @nalind @openshift-merge-robot @TomSweeneyRedHat