feat: f3 implementation by karlem · Pull Request #1469 · consensus-shipyard/ipc

karlem · 2025-10-28T15:52:55Z

Note

Low Risk
Only adds temporary/generated storage layout output files; no runtime or contract logic changes. Main risk is accidental inclusion of build artifacts in the repo.

Overview
Adds two new temporary artifacts, .tmp_gateway_storage_layout.json and .tmp_gateway_storage_layout.txt, capturing the storage layout summary for GatewayDiamond (GatewayActorStorage at slot 0, 1056 bytes). No functional code changes are included in this diff.

^{Written by Cursor Bugbot for commit fb14405. This will update automatically on new commits. Configure here.}

fendermint/vm/interpreter/src/fvm/topdown.rs

fendermint/actors/f3-light-client/src/state.rs

fendermint/actors/f3-light-client/src/lib.rs

fendermint/app/src/service/topdown.rs

fendermint/vm/interpreter/src/fvm/f3_topdown.rs

fendermint/vm/interpreter/src/fvm/topdown.rs

fendermint/vm/message/src/ipc.rs

fendermint/vm/topdown/proof-service/src/service.rs

fendermint/vm/interpreter/src/fvm/f3_topdown.rs

fendermint/vm/message/src/ipc.rs

fendermint/actors/f3-light-client/src/lib.rs

fendermint/vm/interpreter/src/fvm/topdown.rs

fendermint/vm/topdown/proof-service/src/assembler.rs

fendermint/vm/topdown/proof-service/src/cache.rs

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

fendermint/app/src/service/topdown.rs

fendermint/actors/f3-light-client/src/types.rs

fendermint/vm/evm-event-utils/src/lib.rs

fendermint/vm/interpreter/src/fvm/topdown.rs

fendermint/vm/topdown/proof-service/src/assembler.rs

fendermint/vm/topdown/proof-service/src/cache.rs

fendermint/actors/f3-light-client/src/types.rs

fendermint/vm/interpreter/src/fvm/topdown.rs

fendermint/app/src/service/topdown.rs

fendermint/app/src/cmd/genesis.rs

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

fendermint/app/src/service/topdown.rs

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-12T12:12:50Z

.tmp_gateway_storage_layout.json

+=========================================================================================================+
+| s    | struct GatewayActorStorage | 0    | 0      | 1056  | contracts/GatewayDiamond.sol:GatewayDiamond |
+╰------+----------------------------+------+--------+-------+---------------------------------------------╯
+


Accidentally committed temporary build artifact files

Medium Severity

.tmp_gateway_storage_layout.json and .tmp_gateway_storage_layout.txt are temporary build artifacts (Solidity storage layout outputs) that appear to have been accidentally committed. They are not in .gitignore and don't belong in the repository.

Additional Locations (1)

.tmp_gateway_storage_layout.txt#L1-L7

cursor · 2026-03-12T12:12:50Z

fendermint/app/Cargo.toml

-ipc_actors_abis = { path = "../../contract-bindings" }
-ethers = {workspace =  true}
+# F3 certificate handling
+filecoin-f3-gpbft = { git = "https://github.com/moshababo/rust-f3", branch = "cargo-git-compat" }


rust-f3 dependency points to wrong fork

High Severity

filecoin-f3-gpbft in fendermint/app/Cargo.toml points to moshababo/rust-f3 (branch cargo-git-compat), while the workspace root Cargo.toml and Cargo.lock both reference ChainSafe/rust-f3 (branch main). This fork mismatch means the app crate may resolve a different, potentially incompatible version of filecoin-f3-gpbft than the rest of the workspace, leading to type mismatches or subtle behavioral differences at runtime.

cursor · 2026-03-12T12:12:50Z

Cargo.lock

+version = "0.3.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "8eaf4bc02d17cbdd7ff4c7438cafcdf7fb9a4613313ad11b4f8fefe7d3fa0130"
+


Duplicate package entries in generated Cargo.lock

Medium Severity

Cargo.lock contains duplicate entries for jni 0.21.1, jni-sys 0.3.0, and windows_aarch64_gnullvm 0.42.2. These are likely merge artifacts that produce an invalid lock file, potentially causing cargo to reject the file or behave unpredictably during dependency resolution.

Additional Locations (1)

Cargo.lock#L16071-L16077

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-12T12:27:38Z

.tmp_gateway_storage_layout.json

+=========================================================================================================+
+| s    | struct GatewayActorStorage | 0    | 0      | 1056  | contracts/GatewayDiamond.sol:GatewayDiamond |
+╰------+----------------------------+------+--------+-------+---------------------------------------------╯
+


Temporary build artifacts accidentally committed to repository

Low Severity

Two temporary files (.tmp_gateway_storage_layout.json and .tmp_gateway_storage_layout.txt) appear to be accidentally committed build artifacts, likely from running forge inspect or a similar tool. They are not referenced anywhere in the codebase, contain identical human-readable table content (not JSON despite the .json extension), and the .tmp_ prefix indicates they were never intended to be tracked.

Additional Locations (1)

.tmp_gateway_storage_layout.txt#L1-L7

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-12T12:48:25Z

.tmp_gateway_storage_layout.json

+=========================================================================================================+
+| s    | struct GatewayActorStorage | 0    | 0      | 1056  | contracts/GatewayDiamond.sol:GatewayDiamond |
+╰------+----------------------------+------+--------+-------+---------------------------------------------╯
+


Temporary build artifacts accidentally committed to repository

Low Severity

Two temporary build artifact files (.tmp_gateway_storage_layout.json and .tmp_gateway_storage_layout.txt) with identical content were committed to the repository root. The .tmp_ prefix indicates these are generated intermediate files, and they aren't referenced anywhere in the codebase. They appear to be left over from a Solidity storage layout check.

Additional Locations (1)

.tmp_gateway_storage_layout.txt#L1-L7

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-12T16:51:57Z

.tmp_gateway_storage_layout.json

+=========================================================================================================+
+| s    | struct GatewayActorStorage | 0    | 0      | 1056  | contracts/GatewayDiamond.sol:GatewayDiamond |
+╰------+----------------------------+------+--------+-------+---------------------------------------------╯
+


Temporary build artifacts accidentally committed to repository

Low Severity

Two temporary files (.tmp_gateway_storage_layout.json and .tmp_gateway_storage_layout.txt) appear to be build artifacts from a forge inspect run that were accidentally committed. They are not referenced anywhere in the codebase, are not in .gitignore, and contain identical content. These look like they belong in .gitignore rather than in the repository.

Additional Locations (1)

.tmp_gateway_storage_layout.txt#L1-L7

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-12T17:10:15Z

.tmp_gateway_storage_layout.json

+=========================================================================================================+
+| s    | struct GatewayActorStorage | 0    | 0      | 1056  | contracts/GatewayDiamond.sol:GatewayDiamond |
+╰------+----------------------------+------+--------+-------+---------------------------------------------╯
+


Temporary build artifacts accidentally committed to repository

Low Severity

Two temporary files (.tmp_gateway_storage_layout.json and .tmp_gateway_storage_layout.txt) appear to be accidentally committed build artifacts from forge inspect. They are not referenced anywhere in the codebase, contain identical content, and the .json file is not valid JSON — it's a human-readable table with box-drawing characters. These are not covered by .gitignore.

Additional Locations (1)

.tmp_gateway_storage_layout.txt#L1-L7

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-12T19:03:34Z

.tmp_gateway_storage_layout.json

+=========================================================================================================+
+| s    | struct GatewayActorStorage | 0    | 0      | 1056  | contracts/GatewayDiamond.sol:GatewayDiamond |
+╰------+----------------------------+------+--------+-------+---------------------------------------------╯
+


Temporary build artifacts accidentally committed to repository

Low Severity

Two temporary files (.tmp_gateway_storage_layout.json and .tmp_gateway_storage_layout.txt) with identical content appear to be build artifacts from a Solidity storage layout inspection tool. They have the .tmp_ prefix convention indicating temporary output and are not listed in .gitignore. These files don't belong in version control.

Additional Locations (1)

.tmp_gateway_storage_layout.txt#L1-L7

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-12T19:17:25Z

.tmp_gateway_storage_layout.json

+=========================================================================================================+
+| s    | struct GatewayActorStorage | 0    | 0      | 1056  | contracts/GatewayDiamond.sol:GatewayDiamond |
+╰------+----------------------------+------+--------+-------+---------------------------------------------╯
+


Temporary build artifacts accidentally committed to repository

Low Severity

Two temporary files (.tmp_gateway_storage_layout.json and .tmp_gateway_storage_layout.txt) with identical content appear to be build artifacts that were accidentally committed. The .tmp_ prefix strongly indicates these are transient files. They are not listed in .gitignore, and the .json file contains a plain-text table rather than valid JSON.

Additional Locations (1)

.tmp_gateway_storage_layout.txt#L1-L7

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-12T20:09:14Z

.tmp_gateway_storage_layout.json

+=========================================================================================================+
+| s    | struct GatewayActorStorage | 0    | 0      | 1056  | contracts/GatewayDiamond.sol:GatewayDiamond |
+╰------+----------------------------+------+--------+-------+---------------------------------------------╯
+


Temporary build artifacts accidentally committed to repository

Low Severity

Two temporary files (.tmp_gateway_storage_layout.json and .tmp_gateway_storage_layout.txt) with identical content appear to be build artifacts from a Foundry/Forge storage layout inspection. The .tmp_ prefix strongly suggests these are transient outputs not meant for version control, and they are not listed in .gitignore.

Additional Locations (1)

.tmp_gateway_storage_layout.txt#L1-L7

karlem changed the title ~~feat: init lifecycle~~ feat: F3 e2e lifecycle Oct 29, 2025

karlem force-pushed the f3-lifecycle branch from aecf7f5 to a864009 Compare October 29, 2025 18:25

karlem force-pushed the f3-proofs-cache branch from fbaa095 to b34142d Compare October 29, 2025 18:26

karlem force-pushed the f3-lifecycle branch from a864009 to 1e5125d Compare October 29, 2025 18:27

karlem force-pushed the f3-proofs-cache branch from b34142d to 31feb85 Compare November 4, 2025 15:47

karlem force-pushed the f3-lifecycle branch 2 times, most recently from 91db005 to cbce51c Compare November 4, 2025 17:20

sergefdrv reviewed Nov 4, 2025

View reviewed changes

fendermint/vm/interpreter/src/fvm/topdown.rs Outdated Show resolved Hide resolved

karlem force-pushed the f3-lifecycle branch from cbce51c to 0514cd9 Compare November 5, 2025 16:12

karlem force-pushed the f3-proofs-cache branch from 39e59d6 to bfdc6f7 Compare November 5, 2025 22:26

karlem mentioned this pull request Nov 5, 2025

feat: add F3 proofs cache #1457

Merged

sergefdrv reviewed Nov 10, 2025

View reviewed changes

fendermint/actors/f3-light-client/src/state.rs Outdated Show resolved Hide resolved

karlem force-pushed the f3-proofs-cache branch from 93a1066 to 1747f78 Compare November 28, 2025 19:49

karlem force-pushed the f3-lifecycle branch from 82d5f04 to 9a782ce Compare December 1, 2025 20:45

karlem force-pushed the f3-lifecycle branch from 9a782ce to 5c188b8 Compare December 15, 2025 21:34

Base automatically changed from f3-proofs-cache to main December 18, 2025 16:15

karlem force-pushed the f3-lifecycle branch from 5c188b8 to 801c388 Compare December 19, 2025 16:40

karlem marked this pull request as ready for review January 16, 2026 19:52

karlem requested a review from a team as a code owner January 16, 2026 19:52

cursor bot reviewed Jan 16, 2026

View reviewed changes

fendermint/actors/f3-light-client/src/state.rs Show resolved Hide resolved

fendermint/actors/f3-light-client/src/lib.rs Show resolved Hide resolved

sergefdrv requested changes Jan 22, 2026

View reviewed changes

sergefdrv reviewed Jan 23, 2026

View reviewed changes

fendermint/vm/interpreter/src/fvm/f3_topdown.rs Outdated Show resolved Hide resolved

fendermint/vm/interpreter/src/fvm/f3_topdown.rs Outdated Show resolved Hide resolved

sergefdrv reviewed Jan 23, 2026

View reviewed changes

fendermint/vm/message/src/ipc.rs Outdated Show resolved Hide resolved

sergefdrv reviewed Jan 27, 2026

View reviewed changes

sergefdrv mentioned this pull request Jan 28, 2026

Store parent chain's gateway actor ID on subnet chain #1487

Open

cursor bot reviewed Jan 28, 2026

View reviewed changes

fendermint/app/src/service/topdown.rs Show resolved Hide resolved

sergefdrv reviewed Jan 28, 2026

View reviewed changes

sergefdrv reviewed Jan 29, 2026

View reviewed changes

fendermint/actors/f3-light-client/src/types.rs Outdated Show resolved Hide resolved

fendermint/vm/interpreter/src/fvm/topdown.rs Show resolved Hide resolved

fendermint/app/src/service/topdown.rs Show resolved Hide resolved

sergefdrv reviewed Jan 29, 2026

View reviewed changes

fendermint/app/src/cmd/genesis.rs Show resolved Hide resolved

cursor bot reviewed Feb 2, 2026

View reviewed changes

fendermint/app/src/service/topdown.rs Outdated Show resolved Hide resolved

karlem added 10 commits March 11, 2026 19:14

feat: add extraction tests

9f4357b

feat: loggig and integration test

48cb836

feat: comments

29887b2

feat: update based on next comments

6efb10f

feat: add support for nonce verification

b6d2fdb

feat: comments fixed

60be01a

feat: fix comments

9ba8590

feat: last comments fixed

666eded

fix: make it actually run

e2c6940

fix: comments

e1f56b4

karlem force-pushed the f3-lifecycle branch from 682a9e8 to e1f56b4 Compare March 12, 2026 12:10

karlem changed the title ~~feat: F3 e2e lifecycle~~ f3 implementation Mar 12, 2026

karlem changed the title ~~f3 implementation~~ feat: f3 implementation Mar 12, 2026

cursor bot reviewed Mar 12, 2026

View reviewed changes

fix: add headers

d20c7f5

cursor bot reviewed Mar 12, 2026

View reviewed changes

fix: fmt

5c5df2a

cursor bot reviewed Mar 12, 2026

View reviewed changes

fix: clippy

16d1ee3

cursor bot reviewed Mar 12, 2026

View reviewed changes

fix: fmt

c258489

cursor bot reviewed Mar 12, 2026

View reviewed changes

fix: unit test

8ac8bd4

cursor bot reviewed Mar 12, 2026

View reviewed changes

fix: fmt

7f2d0c8

cursor bot reviewed Mar 12, 2026

View reviewed changes

fix: unit test

fb14405

cursor bot reviewed Mar 12, 2026

View reviewed changes

karlem merged commit 7b49216 into main Mar 12, 2026
18 checks passed

karlem deleted the f3-lifecycle branch March 12, 2026 21:44

Conversation

karlem commented Oct 28, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 12, 2026

Choose a reason for hiding this comment

Accidentally committed temporary build artifact files

Uh oh!

cursor bot Mar 12, 2026

Choose a reason for hiding this comment

rust-f3 dependency points to wrong fork

Uh oh!

cursor bot Mar 12, 2026

Choose a reason for hiding this comment

Duplicate package entries in generated Cargo.lock

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 12, 2026

Choose a reason for hiding this comment

Temporary build artifacts accidentally committed to repository

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 12, 2026

Choose a reason for hiding this comment

Temporary build artifacts accidentally committed to repository

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 12, 2026

Choose a reason for hiding this comment

Temporary build artifacts accidentally committed to repository

karlem commented Oct 28, 2025 •

edited by cursor bot

Loading